Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes module_defaults being incorrectly applied to platform actions #804

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

NilashishC
Copy link
Collaborator

SUMMARY
  • Prevents module_defaults from were being incorrectly applied to the platform action, instead of the concerned module.
  • As an example, setting module_defaults at play level for *_facts did not work due to this issue.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meta/runtime.yml

@NilashishC NilashishC added the bug This issue/PR relates to a bug. label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a19c46d) 85.01% compared to head (8dd56f9) 85.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files         211      211           
  Lines       18230    18230           
=======================================
  Hits        15498    15498           
  Misses       2732     2732           

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/07e0ac282e2549daa4904bd1cda794af

✔️ ansible-galaxy-importer SUCCESS in 6m 15s
✔️ build-ansible-collection SUCCESS in 10m 03s
✔️ ansible-tox-linters SUCCESS in 12m 01s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a7059efd4aeb41e69040d0a5a3876435

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 10m 06s
ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 29m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 28m 26s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 09s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 27m 43s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 34m 50s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 41m 09s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 34s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 36m 18s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 37m 20s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 44m 02s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 32m 04s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 57s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f500d83c74644486a64e06d1292223fa

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 9m 47s
ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 30m 57s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 29m 44s (non-voting)
ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 37m 21s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 29m 07s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable215-scenario01 FAILURE in 36m 01s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario02 SUCCESS in 34m 15s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario03 SUCCESS in 42m 23s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable215-scenario04 SUCCESS in 32m 50s (non-voting)
ansible-test-network-integration-nxos-cli-python39-stable214-scenario01 FAILURE in 35m 08s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario02 SUCCESS in 33m 11s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario03 SUCCESS in 41m 53s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-stable214-scenario04 SUCCESS in 30m 22s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 52s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/899fa7f40f4d4d00b9726ae1154223fa

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 10m 11s
✔️ ansible-tox-linters SUCCESS in 12m 00s

@NilashishC NilashishC merged commit 69499b8 into ansible-collections:main Jan 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants