don't kill the server if some modules are still running #109
Conversation
|
Build failed. ❌ ansible-test-sanity-docker-devel FAILURE in 8m 21s (non-voting) |
goneri
force-pushed
the
don-t-kill-the-server-if-some-modules-are-still-running_12970
branch
from
50426e4
to
2f5072e
Compare
|
Build failed. ❌ ansible-test-sanity-docker-devel FAILURE in 9m 37s (non-voting) |
|
recheck |
|
This change depends on a change that failed to merge. |
|
regate |
|
This change depends on a change that failed to merge. |
goneri
force-pushed
the
don-t-kill-the-server-if-some-modules-are-still-running_12970
branch
from
2f5072e
to
9dd824a
Compare
Ensure we don't have any ongoing task before we shutdown the server.
The syndrome was errors like this:
UnexpectedFailure: Cannot decode plugin answer: b''\n"
Closes: ansible-collections/vmware.vmware_rest#336
goneri
force-pushed
the
don-t-kill-the-server-if-some-modules-are-still-running_12970
branch
from
9dd824a
to
62f3cad
Compare
|
Build succeeded. ✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 14s (non-voting) |
| self.jobs_started = 0 | ||
| self.jobs_done = 0 |
There was a problem hiding this comment.
I feel like you could simplify this by just having a self.task_running boolean variable.
There was a problem hiding this comment.
We can have several tasks running in parallel.
|
|
||
| async def handle(self, reader, writer): | ||
| self._watcher.cancel() | ||
|
|
||
| self.jobs_started += 1 | ||
| raw_data = await reader.read() | ||
| if not raw_data: | ||
| return |
There was a problem hiding this comment.
Isn't this potentially going to lead to the server process never being killed?
|
Build succeeded (gate pipeline). ✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 43s (non-voting) |
turbo: ensure we clean up the leaked jobs See: #109 (comment) Reviewed-by: Mike Graves <mgraves@redhat.com>
Depends-On: #110
Ensure we don't have any ongoing task before we shutdown the server.
The syndrome was errors like this:
Closes: ansible-collections/vmware.vmware_rest#336