Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #143/86b1ee44 backport][stable-3] Move turbo server import statements into try/except block #147

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 23, 2024

This is a backport of PR #143 as merged into main (86b1ee4).

SUMMARY

Fixes a bug where one import statement was outside the try/except block in the turbo server run_as_lookup_plugin() function. Because this is run in an async loop inside a subprocess, unhandled exceptions can cause strange behavior so it's better to have all the import statements in a try/except block that returns error messages to the user.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils.turbo.server

Copy link

Move turbo server import statements into try/except block

(cherry picked from commit 86b1ee4)
@alinabuzachis alinabuzachis force-pushed the patchback/backports/stable-3/86b1ee44aed2b9fd45fae287e275ec978cdd132a/pr-143 branch from 28cc444 to 8b0507d Compare May 23, 2024 13:22
Copy link

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/4937f8b62d7e41b99471865ad29a2a53

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 9m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 42457e2 into stable-3 May 23, 2024
42 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/86b1ee44aed2b9fd45fae287e275ec978cdd132a/pr-143 branch May 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants