Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0] Complete deprecations for iam_server_certificate #1257

Closed
1 task done
tremble opened this issue Jun 24, 2022 · 2 comments · Fixed by #1265
Closed
1 task done

[5.0.0] Complete deprecations for iam_server_certificate #1257

tremble opened this issue Jun 24, 2022 · 2 comments · Fixed by #1265
Labels
bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type)

Comments

@tremble
Copy link
Contributor

tremble commented Jun 24, 2022

Summary

cert_chain, cert and key were slated for removal in 4.0.0
dup_ok was due to change default value in 4.0.0

we missed the boat.

  • Bump the deprecation version (backport to stable-4)
  • Apply changes (don't backport)

Issue Type

Bug Report

Component Name

iam_server_certificate

Ansible Version

CI

Collection Versions

CI

AWS SDK versions

CI

Configuration

CI

OS / Environment

CI

Steps to Reproduce

Run sanity tests without ignore files

Expected Results

No errors

Actual Results

2022-06-24 08:03:16.931794 | controller | ERROR: Found 4 pylint issue(s) which need to be resolved:
2022-06-24 08:03:16.931861 | controller | ERROR: plugins/modules/iam_server_certificate.py:321:8: collection-deprecated-version: Deprecated version ('4.0.0') found in call to Display.deprecated or AnsibleModule.deprecate
2022-06-24 08:03:16.931881 | controller | ERROR: plugins/modules/iam_server_certificate.py:328:8: collection-deprecated-version: Deprecated version ('4.0.0') found in call to Display.deprecated or AnsibleModule.deprecate
2022-06-24 08:03:16.931897 | controller | ERROR: plugins/modules/iam_server_certificate.py:335:8: collection-deprecated-version: Deprecated version ('4.0.0') found in call to Display.deprecated or AnsibleModule.deprecate
2022-06-24 08:03:16.931927 | controller | ERROR: plugins/modules/iam_server_certificate.py:408:8: collection-deprecated-version: Deprecated version ('4.0.0') found in call to Display.deprecated or AnsibleModule.deprecate

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@tremble tremble mentioned this issue Jun 24, 2022
Merged
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type) labels Jun 24, 2022
This was referenced Jun 25, 2022
Closed
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jun 28, 2022
@tremble
[5.0.0] iam_server_cerificate - complete deprecation cycle and remove…
058ecff 
… support (#1265)

[5.0.0] iam_server_cerificate - complete deprecation cycles

SUMMARY
fixes: #1257
In #735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True.
This PR completes the deprecation cycle (1 release late)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
@renovate renovate bot mentioned this issue Aug 8, 2022
Merged
1 task
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
@tremble
Mass remove Python 2.x compatibility code (ansible-collections#1257)
680cfc8 
Mass remove Python 2.x compatibility code

Depends-On: ansible-collections#1259
SUMMARY
We dropped support for Python < 3.6 in release 2.0, and ansible-test now respects this and doesn't complain about the missing compatibility code, so drop the extra code
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/
tests/unit/
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
@tremble @alinabuzachis
iam_server_cerificate - complete deprecation cycle and remove support (…
6d822e0 
…ansible-collections#1265)

[5.0.0] iam_server_cerificate - complete deprecation cycles

SUMMARY
fixes: ansible-collections#1257
In ansible-collections#735 we deprecated passing filenames and prepared to switch the default value of dup_ok to True.
This PR completes the deprecation cycle (1 release late)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@058ecff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug has_pr module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5.0.0] iam_server_cerificate - complete deprecation cycles tremble/community.aws
2 participants
@tremble @ansibullbot