elb_network_lb always shown as changed

[mszumilak]

SUMMARY

elb_network_lb shows state of LB as changed with no changes made.

ISSUE TYPE

• Bug Report

COMPONENT NAME

elb_nework_lb

ANSIBLE VERSION

ansible [core 2.11.1] 
  config file = /home/x/ansible.cfg
  configured module search path = ['/home/x/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/x/venvs/ansible/lib/python3.8/site-packages/ansible
  ansible collection location = /home/x/.ansible/collections
  executable location = /home/x/venvs/ansible/bin/ansible
  python version = 3.8.5 (default, May 27 2021, 13:30:53) [GCC 9.3.0]
  jinja version = 3.0.1
  libyaml = True

CONFIGURATION

n/a

OS / ENVIRONMENT

n/a

STEPS TO REPRODUCE

Create NLB and re-run the same task/playbook

- name: Create internal NLB
  elb_network_lb:
    name: "my-internal-nlb"
    deletion_protection: True
    subnets: "{{ private_elb_subnets }}"
    scheme: internal
    listeners:
      - Protocol: TCP
        Port: 5555
        DefaultActions:
          - Type: forward
            TargetGroupName: "{{ target_group_1_name }}"
      - Protocol: TCP
        Port: 5556
        DefaultActions:
          - Type: forward
            TargetGroupName: "{{ target_group_2_name }}"
    state: present
    region: "{{ aws_region }}"

EXPECTED RESULTS

I'd exect this module to show no changes if there are no changes.

ACTUAL RESULTS

Every time I run the playbook the NLB task is shown as changed

TASK [aws/eks : Create internal NLB] ******************************************
changed: [localhost]

[ansibullbot]

Files identified in the description:

• [plugins/modules/elb_network_lb.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/elb_network_lb.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

[markuman]

The error is happening in amazon.aws collection plugins/module_utils/elbv2.py L618 and following lines

  0.0s compare_listeners: 
      new_listener={'DefaultActions': [{'TargetGroupArn': 'arn:aws:elasticloadbalancing:eu-central-1:111:targetgroup/test1/d277d07b1a53b119', 'Type': 'forward'}], 'Port': 5555, 'Protocol': 'TCP'}
 0.0s _compare_listener: 
      current_listener['DefaultActions']=[{'ForwardConfig': {'TargetGroups': [{'TargetGroupArn': 'arn:aws:elasticloadbalancing:eu-central-1:111:targetgroup/test1/d277d07b1a53b119'}]}, 'TargetGroupArn': 'arn:aws:elasticloadbalancing:eu-central-1:111:targetgroup/test1/d277d07b1a53b119', 'Type': 'forward'}]

this fixes the issue

diff --git a/plugins/module_utils/elbv2.py b/plugins/module_utils/elbv2.py
index 8ad0bbf..563a542 100644
--- a/plugins/module_utils/elbv2.py
+++ b/plugins/module_utils/elbv2.py
@@ -616,6 +616,7 @@ class ELBListeners(object):
         # If the lengths of the actions are the same, we'll have to verify that the
         # contents of those actions are the same
         if len(current_listener['DefaultActions']) == len(new_listener['DefaultActions']):
+            current_listener['DefaultActions'][0].pop('ForwardConfig')
             current_actions_sorted = _sort_actions(current_listener['DefaultActions'])
             new_actions_sorted = _sort_actions(new_listener['DefaultActions'])
 

results in

TASK [Create internal NLB] **********************************************************************************************************************************************************************************************************
ok: [localhost]

but maybe breaks other things? a PR/Issue in amazon.aws is necessary.

[hectoralicea]

I have the opposite issue. When I re-run my create elb with static IPs I get the following error:

TASK [ansible-role-aws-ingress-controller : install-nlb-to-ingress.yaml | create an internal ELB with a specified IP address] ********************************************
fatal: [localhost]: FAILED! => changed=false 
  msg: Modifying subnets and elastic IPs is not supported for Network Load Balancer

it should state "ok:" since nothing is being changed.

[tremble]

@hectoralicea the error you're seeing looks like it's unrelated, please open a separate issue.

[tremble]

@mszumilak hopefully the issue you're hitting will be fixed by ansible-collections/amazon.aws#940