Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - remove default empty dict where purge_tags default is True #1183

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 30, 2022

Depends-On: ansible-collections/amazon.aws#844

SUMMARY
  • Move modules over to the new tagging fragment
  • Update modules to remove default tags of {} and use None instead, so that purging tags only happens if someone explicitly passes the tags parameter
ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

plugins/modules/ec2_transit_gateway.py
plugins/modules/efs.py
plugins/modules/eks_fargate_profile.py
plugins/modules/elb_target_group.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented May 30, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels May 30, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 08s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 48s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 27s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 10s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 23s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-community.aws-1 SUCCESS in 24m 47s
✔️ integration-community.aws-2 SUCCESS in 35m 42s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 38s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 47s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 46s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 45s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 36s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 28s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 22s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 34s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-community.aws-1 SUCCESS in 20m 07s
✔️ integration-community.aws-2 SUCCESS in 32m 43s
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7d98adc into ansible-collections:main Jun 1, 2022
@tremble tremble deleted the tagging/default_dict branch July 7, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants