route53_info: Add snake_cased return key,values to remaining methods #1322
Conversation
ansibullbot
added
bug
There was a problem hiding this comment.
The old keys should still be returned in addition to the new ones you added (with a deprecation message etc etc). Also, it has to be muuuch easier to simply camel_dict_to_snake_dict the final results prior to module.exit_json, rather than going through and modifying each individual key thats CamelCased. That's why we have module utils ;)
Yes, the old keys(camel_cased) are still being returned along with the new (snake_cased) keys. also yes, using Added the deprecation warnings. |
tremble
added
backport-3
There was a problem hiding this comment.
Thanks @mandar242,
Since the original PR (#1236) already got released we need a changelog to go with this.
Additionally I don't see any return value documentation, and some integration tests would also be good...
ansibullbot
added
needs_revision
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
and removed
needs_revision
tremble
added
mergeit
|
regate |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1327 🤖 @patchback |
…1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on #1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit d7f3862)
…1322) (#1327) [PR #1322/d7f38627 backport][stable-4] route53_info: Add snake_cased return key,values to remaining methods This is a backport of PR #1322 as merged into main (d7f3862). SUMMARY Following up on #1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Mark Chappell <None>
…nsible-collections#1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on ansible-collections#1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@d7f3862
ec2_snapshot - stability - relax integration tests SUMMARY When using pagination, you're not guaranteed to get "max_items", it's a maximum. Sometimes you'll get less. Relax the ec2_snapshot tests a little to take this into account. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_snapshot ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Bulk update imports after reshuffle Depends-On: ansible-collections#1323 Depends-On: ansible-collections#1322 Depends-On: ansible-collections#1321 SUMMARY module_utils code got split up. Bulk update the imports to reflect this ISSUE TYPE Feature Pull Request COMPONENT NAME various ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
SUMMARY
Following up on #1236
Found more places where
route53_infomodule does not return a snake_case output.Added snake_case output to
checker_ip_range_details,reusable_delegation_set_details, andget_health_checkmethods.ISSUE TYPE
COMPONENT NAME
route53_info