[PR #1330/40984a40 backport][stable-4] s3_sync - Improve error handling when testing for existing files #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
s3_sync - Improve error handling when testing for existing files SUMMARY fixes: #58 Simplifies handling of '404' codes (use is_boto3_error_code) Assume 403 files need updating (it's the best we can do, and mimics aws cli) Allows Boto3 exceptions to fall through to the outer try/except clause and cleanly fail rather than rethrowing it as an Exception() ISSUE TYPE Feature Pull Request COMPONENT NAME s3_sync ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 40984a4)
tremble
approved these changes
Jul 9, 2022
ansibullbot
added
community_review
feature
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/40984a403c150b31cd58236028ae0d0945c161f0/pr-1330
branch
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ame` (ansible-collections#1335) route53_health_check: rescind deprecation message for `health_check_name` SUMMARY Rescind deprecation message as nonessential due to below reasons health_check_id and health_check_name being mutually exclusive module currently provides functionality to update/delete by name and id both, which would not be the case if the deprecation changes are made. can update by ID / delete by ID can update by name+use_unique_names / delete by name+use_unique_names can create single health check without name and use_unique_names can create multiple health checks with name+use_unique_names COMPONENT NAME route53_health_check Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1330 as merged into main (40984a4).
SUMMARY
fixes: #58
ISSUE TYPE
COMPONENT NAME
s3_sync
ADDITIONAL INFORMATION