Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #488/3ad3b97f backport][stable-5] Support new enableExecuteCommand options for ECS service #1752

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 20, 2023

This is a backport of PR #488 as merged into main (3ad3b97).

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_service

ADDITIONAL INFORMATION

Create ECS service with enable_execute_command option,

- name: create exec service
  ecs_service:
    state: present
    ...
    enable_execute_command: true

and we can exec ECS task

$ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash


The Session Manager plugin was installed successfully. Use the AWS CLI to start a session.


Starting session with SessionId: ecs-execute-command-0c17f94b36227381f
root@ip-10-0-66-68:/#

Support new enableExecuteCommand options for ECS service

SUMMARY

Support new ecs exec feature for ECS service

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION

Create ECS service with enable_execute_command option,
- name: create exec service
  ecs_service:
    state: present
    ...
    enable_execute_command: true

and we can exec ECS task
$ aws ecs execute-command --cluster xxxxx --task arn:aws:ecs:us-east-1:*****:task/webapp/***** --container xxxxx --interactive --command /bin/bash

The Session Manager plugin was installed successfully. Use the AWS CLI to start a session.

Starting session with SessionId: ecs-execute-command-0c17f94b36227381f
root@ip-10-0-66-68:/#

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
(cherry picked from commit 3ad3b97)
@github-actions
Copy link

github-actions bot commented Mar 20, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e3ae05456cbc4461ae525fe07bf3caaf

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 13m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 07s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 13s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 04s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 34s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 06s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 07s
✔️ ansible-test-changelog SUCCESS in 4m 23s
✔️ ansible-test-splitter SUCCESS in 4m 54s
integration-community.aws-1 FAILURE in 19m 17s
Skipped 21 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/468e7fb014e14d878c42e3b3ddc88ccb

✔️ ansible-galaxy-importer SUCCESS in 3m 30s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 12s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 42s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 39s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 12m 10s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 20s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 53s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 50s
✔️ ansible-test-changelog SUCCESS in 4m 26s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-community.aws-1 SUCCESS in 19m 17s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7cc54f3 into stable-5 Mar 20, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/3ad3b97fc528008f7e1cbdf9cc0cec3d093314e1/pr-488 branch March 20, 2023 11:45
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_ami - fix org-owner version_added

SUMMARY
ansible-collections#1735 missed the 6.4.0 cutoff, update version_added.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_ami
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants