Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote iam_group module #1945

Merged
merged 3 commits into from Sep 20, 2023
Merged

Promote iam_group module #1945

merged 3 commits into from Sep 20, 2023

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Sep 13, 2023 •
edited

SUMMARY
  • Remove iam_group modules and tests
  • These modules have been migrated to amazon.aws
  • Update runtime.yml with redirects to that collection
  • Update ignore files

related to ansible-collections/amazon.aws#1755

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@mandar242 mandar242 mentioned this pull request Sep 13, 2023
Merged
@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/73d642938e73448a8756c9787f0a7bf6

✔️ ansible-galaxy-importer SUCCESS in 9m 24s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 15s
✔️ ansible-test-splitter SUCCESS in 4m 47s
Skipped 22 jobs

tremble
tremble requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, runtime.yml indentation changed, old "main"?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7d3cb6a31943485aad93b1f93ef41340

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 01s
✔️ ansible-test-splitter SUCCESS in 4m 58s
Skipped 22 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ecbc65159c6c47c68558ba10c0b72312

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 01s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-splitter SUCCESS in 4m 43s
Skipped 22 jobs

softwarefactory-project-zuul bot pushed a commit to ansible-collections/amazon.aws that referenced this pull request Sep 19, 2023
@mandar242
Promote iam_group module (#1755)
dbb569c 
Promote iam_group module

SUMMARY

Migrate iam_group module from community.aws

related to ansible-collections/community.aws#1945
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Bikouo Aubin
Reviewed-by: Alina Buzachis
@mandar242
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7e79e9b5e8f641cba81061e39d2d01bf

❌ ansible-galaxy-importer FAILURE in 5m 19s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 55s
✔️ ansible-test-splitter SUCCESS in 4m 58s
Skipped 22 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Sep 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/6776898d1d2041b7884deb834b82054b

✔️ ansible-galaxy-importer SUCCESS in 4m 17s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 5m 15s
Skipped 22 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bac5820 into ansible-collections:main Sep 20, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@hakbailey hakbailey hakbailey approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@abikouo abikouo abikouo approved these changes

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mandar242 @tremble @hakbailey @alinabuzachis @abikouo