Use HeadBucket instead of GetBucketLocation (#1979) #1987

raulpedroche · 2023-10-25T07:48:10Z

SUMMARY

Replacing the call to get_bucket_location with a call to head_bucket in Connection._get_bucket_endpoint().

The GetBucketLocation API call only works from the bucket owner account. This enables using a bucket owned by another accout, e.g. a shared organization bucket when running cross-account.

Fixes #1979.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_ssm

ADDITIONAL INFORMATION

The official documentation for the GetBucketLocation API call states it is only supported for backwards compatibility and recomends using HeadBucket instead.

# Before change
PLAY [Minimal playbook] ********************************************************

TASK [Gathering Facts] *********************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the GetBucketLocation operation: Access Denied
fatal: [i-00a8cb5930bd5f7dc]: FAILED! => {"msg": "Unexpected failure during module execution: An error occurred (AccessDenied) when calling the GetBucketLocation operation: Access Denied", "stdout": ""}

PLAY RECAP *********************************************************************
i-00a8cb5930bd5f7dc        : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0 

# After change
PLAY [Minimal playbook] ********************************************************

TASK [Gathering Facts] *********************************************************
Warning: : Platform linux on host i-00a8cb5930bd5f7dc is using the discovered
Python interpreter at /usr/libexec/platform-python, but future installation of
another Python interpreter could change the meaning of that path. See
https://docs.ansible.com/ansible-
core/2.15/reference_appendices/interpreter_discovery.html for more information.
ok: [i-00a8cb5930bd5f7dc]

TASK [Ping] ********************************************************************
ok: [i-00a8cb5930bd5f7dc]

PLAY RECAP *********************************************************************
i-00a8cb5930bd5f7dc        : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

softwarefactory-project-zuul · 2023-10-25T08:15:22Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6eda50db34d649d29d271dd5432c5cd0

❌ ansible-galaxy-importer FAILURE in 5m 27s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-splitter SUCCESS in 5m 13s
✔️ integration-community.aws-1 SUCCESS in 9m 50s
✔️ integration-community.aws-2 SUCCESS in 12m 37s
✔️ integration-community.aws-3 SUCCESS in 6m 37s
Skipped 19 jobs

fivetran-joliveira · 2023-11-02T16:30:47Z

When trying to use a single organization bucket for cross-account connection

I'm facing the same error reported on #1979 in this exact scenario: single bucket for cross account connection
I'd love to see this PR merged. 🤞

mdaffernaderant · 2024-02-19T22:03:26Z

Would like to see this merged as well. Facing the exact error too.

jacksod1 · 2024-04-12T15:05:02Z

What needs to be done in order to get this PR merged? I'd love to see this merged as well.

dicknetherlands · 2024-06-06T00:40:52Z

I have the same problem with this plugin and GetBucketLocation and it is blocking me from doing production deployments in a multi-region environment using Ansible and SSM.

When might this PR be reviewed/merged?

markuman · 2024-06-07T09:42:40Z

recheck

softwarefactory-project-zuul · 2024-06-07T09:42:49Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.aws for 1987,ddb05fe12eb3cd25e8cc6c84014b8e6f5791ad29

softwarefactory-project-zuul · 2024-06-07T10:39:33Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b2758ed4612b4500a110197e8e1791b4

❌ ansible-galaxy-importer FAILURE in 5m 30s (non-voting)
✔️ build-ansible-collection SUCCESS in 18m 08s
✔️ ansible-test-splitter SUCCESS in 6m 49s
✔️ integration-community.aws-1 SUCCESS in 10m 45s
✔️ integration-community.aws-2 SUCCESS in 9m 49s
✔️ integration-community.aws-3 SUCCESS in 9m 49s
✔️ integration-community.aws-4 SUCCESS in 10m 59s
✔️ integration-community.aws-5 SUCCESS in 10m 13s
✔️ integration-community.aws-6 SUCCESS in 10m 30s
✔️ integration-community.aws-7 SUCCESS in 8m 45s
✔️ integration-community.aws-8 SUCCESS in 10m 56s
✔️ integration-community.aws-9 SUCCESS in 8m 27s
✔️ integration-community.aws-10 SUCCESS in 9m 48s
✔️ integration-community.aws-11 SUCCESS in 9m 36s
Skipped 11 jobs

n0ct1s-k8sh · 2024-06-13T12:19:14Z

Hi. I'm also affected in my job production environment.

Is there any major problem?

Thanks.

markuman · 2024-06-13T16:58:18Z

Hi. I'm also affected in my job production environment.

Is there any major problem?

Thanks.

Currently we need a 2nd review.

cc @tremble @jillr @alinabuzachis @hakbailey

iomarcovalente · 2024-06-14T15:24:45Z

this is also blocking us. looking foward to see it merged

markuman · 2024-06-23T06:21:54Z

regate

alinabuzachis · 2024-06-28T12:59:09Z

regate

softwarefactory-project-zuul · 2024-06-28T13:56:08Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/8c1a5f00231d4290b41f705a8eabc906

❌ ansible-galaxy-importer FAILURE in 4m 38s (non-voting)
✔️ build-ansible-collection SUCCESS in 13m 00s
✔️ ansible-test-splitter SUCCESS in 5m 07s
❌ integration-community.aws-1 FAILURE in 12m 55s
❌ integration-community.aws-2 FAILURE in 13m 48s
❌ integration-community.aws-3 FAILURE in 12m 59s
❌ integration-community.aws-4 FAILURE in 12m 42s
❌ integration-community.aws-5 FAILURE in 12m 22s
❌ integration-community.aws-6 FAILURE in 12m 49s
❌ integration-community.aws-7 FAILURE in 12m 54s
❌ integration-community.aws-8 FAILURE in 12m 28s
❌ integration-community.aws-9 FAILURE in 11m 45s
❌ integration-community.aws-10 FAILURE in 12m 32s
✔️ integration-community.aws-11 SUCCESS in 5m 44s
Skipped 11 jobs

markuman · 2024-06-28T15:30:32Z

regate

softwarefactory-project-zuul · 2024-06-28T16:20:54Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/71748f80e37541efb5c7238fe1edee4f

✔️ ansible-galaxy-importer SUCCESS in 8m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 53s
✔️ ansible-test-splitter SUCCESS in 5m 00s
❌ integration-community.aws-1 FAILURE in 13m 34s
❌ integration-community.aws-2 FAILURE in 11m 54s
❌ integration-community.aws-3 FAILURE in 12m 58s
❌ integration-community.aws-4 FAILURE in 13m 50s
❌ integration-community.aws-5 FAILURE in 14m 41s
❌ integration-community.aws-6 FAILURE in 12m 39s
❌ integration-community.aws-7 FAILURE in 11m 31s
❌ integration-community.aws-8 FAILURE in 12m 48s
❌ integration-community.aws-9 FAILURE in 12m 45s
❌ integration-community.aws-10 FAILURE in 11m 11s
✔️ integration-community.aws-11 SUCCESS in 5m 23s
Skipped 11 jobs

markuman · 2024-07-02T18:33:37Z

regate

softwarefactory-project-zuul · 2024-07-02T19:07:35Z

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/508bc8621a3d4e71ab5ec9576557cf99

❌ ansible-galaxy-importer FAILURE in 4m 35s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-splitter SUCCESS in 5m 13s
❌ integration-community.aws-1 FAILURE in 13m 21s
❌ integration-community.aws-2 FAILURE in 13m 49s
❌ integration-community.aws-3 FAILURE in 12m 09s
❌ integration-community.aws-4 FAILURE in 12m 51s
❌ integration-community.aws-5 FAILURE in 13m 01s
❌ integration-community.aws-6 FAILURE in 11m 38s
❌ integration-community.aws-7 FAILURE in 15m 40s
❌ integration-community.aws-8 FAILURE in 12m 47s
❌ integration-community.aws-9 FAILURE in 11m 31s
❌ integration-community.aws-10 FAILURE in 11m 57s
✔️ integration-community.aws-11 SUCCESS in 5m 32s
Skipped 11 jobs

raulpedroche and others added 2 commits June 7, 2024 11:56

Use HeadBucket instead of GetBucketLocation (ansible-collections#1979)

4defdfe

add changelog fragment

c9a3758

markuman force-pushed the raulpedroche/issue1979 branch from ba06771 to c9a3758 Compare June 7, 2024 09:57

markuman added backport-7 PR should be backported to the stable-7 branch backport-8 labels Jun 7, 2024

fix indent

8dc063a

markuman requested a review from alinabuzachis June 7, 2024 10:14

markuman approved these changes Jun 7, 2024

View reviewed changes

markuman requested a review from hakbailey June 7, 2024 10:15

alinabuzachis approved these changes Jun 21, 2024

View reviewed changes

alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jun 21, 2024

markuman added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Jun 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use HeadBucket instead of GetBucketLocation (#1979) #1987

Use HeadBucket instead of GetBucketLocation (#1979) #1987

raulpedroche commented Oct 25, 2023

softwarefactory-project-zuul bot commented Oct 25, 2023

fivetran-joliveira commented Nov 2, 2023

mdaffernaderant commented Feb 19, 2024 •

edited

Loading

jacksod1 commented Apr 12, 2024

dicknetherlands commented Jun 6, 2024

markuman commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

n0ct1s-k8sh commented Jun 13, 2024

markuman commented Jun 13, 2024

iomarcovalente commented Jun 14, 2024

markuman commented Jun 23, 2024

alinabuzachis commented Jun 28, 2024

softwarefactory-project-zuul bot commented Jun 28, 2024

markuman commented Jun 28, 2024

softwarefactory-project-zuul bot commented Jun 28, 2024

markuman commented Jul 2, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

Use HeadBucket instead of GetBucketLocation (#1979) #1987

Are you sure you want to change the base?

Use HeadBucket instead of GetBucketLocation (#1979) #1987

Conversation

raulpedroche commented Oct 25, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Oct 25, 2023

fivetran-joliveira commented Nov 2, 2023

mdaffernaderant commented Feb 19, 2024 • edited Loading

jacksod1 commented Apr 12, 2024

dicknetherlands commented Jun 6, 2024

markuman commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

softwarefactory-project-zuul bot commented Jun 7, 2024

n0ct1s-k8sh commented Jun 13, 2024

markuman commented Jun 13, 2024

iomarcovalente commented Jun 14, 2024

markuman commented Jun 23, 2024

alinabuzachis commented Jun 28, 2024

softwarefactory-project-zuul bot commented Jun 28, 2024

markuman commented Jun 28, 2024

softwarefactory-project-zuul bot commented Jun 28, 2024

markuman commented Jul 2, 2024

softwarefactory-project-zuul bot commented Jul 2, 2024

mdaffernaderant commented Feb 19, 2024 •

edited

Loading