Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iam_managed_policy_attachment module #32

Closed

Conversation

rbobrowicz
Copy link

SUMMARY

There is no existing module for attaching managed policies to iam entities. iam_managed_policy can create managed policies, but iam_policy can only attach inline policies. This PR adds iam_managed_policy_attachment to fill the gap.

We've been using this at my work for close to a year, I decided to clean it up and make a PR. It addresses ansible/ansible#31999

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

iam_managed_policy_attachment

ADDITIONAL INFORMATION

@rbobrowicz rbobrowicz changed the title adds iam_managed_policy_attachment module add iam_managed_policy_attachment module Apr 8, 2020
@jillr jillr changed the base branch from master to main July 2, 2020 19:48
@ansibullbot
Copy link

@ansibullbot ansibullbot added affects_2.10 community_review module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin stale_ci CI is older than 7 days, rerun before merging labels Aug 19, 2020
@ansibullbot ansibullbot added the plugins plugin (any type) label Aug 28, 2020
@ansibullbot
Copy link

@Akasurde @BobBoldin @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Shaps @Sodki @Zeekin @aidan- @akazakov @alachaum @aljazkosir @amir343 @anryko @axc450 @bekelchik @bpennypacker @brandond @captainkerk @chenl87 @defionscode @defunctio @dennisconrad @dkhenry @erydo @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @jimbydamonk @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @kaczynskid @leedm777 @linuxdynasty @loia @markuman @matt-telstra @michaeljs1990 @miha-plesko @mikedlr @minichate @mjschultz @mmochan @mmoyle @mpechner @mtraynham @nadirollo @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rafaeldriutti @rickmendes @rrey @ruimoreira @ryansb @ryansydnor @s-hertel @sbj-ss @scottanderson42 @seiffert @shepdelacreme @simplesteph @slapula @stefanhorning @steynovich @tastychutney @tdekeyser @tedder @timmahoney @tomislacker @tremble @tsiganenok @viper233 @vorotech @willricardo @willthames @wilvk @wimnat @xlab-si @yaakov-github @zacblazic @Zeekin @zimbatm

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407 label Dec 1, 2020
@tremble
Copy link
Contributor

tremble commented Dec 1, 2020

Hi @rbobrowicz

Sorry it's taken so long to get back to you and thank you for the time you've taken in writing the module and opening this PR.

The iam_user, iam_group and iam_role modules have a 'managed_policies' parameter which I think achieves what this module is trying to do, is there a specific use case that you feel is missed by the managed_policies parameters?

@rbobrowicz
Copy link
Author

Huh, I guess I either missed those or that wasn't around when I first ran into this issue. When I tried to figure out how to attach managed policies in the past I stumbled into the issue I linked in my opening PR which suggested these features weren't available, so I rolled my own and thought I'd contribute it back. I'll take a closer look at the'managed_policies paramater tomorrow and close the PR if my module is no longer required.

@rbobrowicz rbobrowicz closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 community_review module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407 stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants