Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eip association when both instance id and private ip address are passed #328

Merged
merged 3 commits into from Dec 15, 2020
Merged

Fix eip association when both instance id and private ip address are passed #328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7acce9d
Fix ec2_eip with both instance_id and private_ip_address
Phoosha Dec 10, 2020
6543c11
Add changelog fragment for the ec2_eip fix
Phoosha Dec 10, 2020
a9d08ee
Update changelogs/fragments/328-fix-ec2_eip-instance-id-private-ip-ad…
tremble Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/modules/ec2_eip.py
View file
Open in desktop
Expand Up @@ -241,7 +241,7 @@ def associate_ip_and_device(ec2, module, address, private_ip_address, device_id,
AllowReassociation=allow_reassociation,
)
if private_ip_address:
params['PrivateIPAddress'] = private_ip_address
params['PrivateIpAddress'] = private_ip_address
if address['Domain'] == 'vpc':
params['AllocationId'] = address['AllocationId']
else:
Expand Down
16 changes: 16 additions & 0 deletions tests/integration/targets/ec2_eip/tasks/main.yml
View file
Open in desktop
Expand Up @@ -569,6 +569,22 @@
- instance_eip is success
- eip_info.addresses[0].allocation_id is defined
- eip_info.addresses[0].instance_id == '{{ instance_info.instances[0].instance_id }}'
- name: Attach eip to an EC2 instance with private Ip specified
ec2_eip:
device_id: '{{ instance_info.instances[0].instance_id }}'
private_ip_address: '{{ instance_info.instances[0].private_ip_address }}'
state: present
release_on_disassociation: yes
register: instance_eip
- ec2_eip_info:
filters:
public-ip: '{{ instance_eip.public_ip }}'
register: eip_info
- assert:
that:
- instance_eip is success
- eip_info.addresses[0].allocation_id is defined
- eip_info.addresses[0].instance_id == '{{ instance_info.instances[0].instance_id }}'
# =====================================================
- name: Cleanup IGW
ec2_vpc_igw:
Expand Down