ec2_eip tagging support #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
tagging/ec2_eip
branch
from
e1d04ae
to
f2e7e65
Compare
ansibullbot
added
WIP
tremble
force-pushed
the
tagging/ec2_eip
branch
from
e1a8955
to
7a5fa4f
Compare
tremble
force-pushed
the
tagging/ec2_eip
branch
from
7a5fa4f
to
cc9bac3
Compare
ghost
approved these changes
Oct 16, 2021
tremble
force-pushed
the
tagging/ec2_eip
branch
from
cc9bac3
to
9977e21
Compare
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_eip tagging support SUMMARY Add support for tagging EIPs on creation. Todo: EIP Tagging Tests Retry decorator Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip ec2_eip_info ADDITIONAL INFORMATION fixes: ansible-collections#331 Reviewed-by: Rick Mendes <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@02836f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for tagging EIPs on creation.
Todo:
Note: While it's now possible to pass tagging information into the association call this was only added Dec 2020 so won't work for most folks.
ISSUE TYPE
COMPONENT NAME
ec2_eip
ec2_eip_info
ADDITIONAL INFORMATION
fixes: #331