Fix target group remove / add logic

[msven]

SUMMARY

Fixes target group update logic to support updating target groups when the final number
of target groups attached to the asg remains the same.

Fixes #492

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ec2_asg

ADDITIONAL INFORMATION

Integration tests were added to validate the change. The following test would've previously failed the final assertion.

- name: update autoscaling group tg2
  ec2_asg:
    name: "{{ resource_prefix }}-asg"
    launch_template: 
      launch_template_name: "{{ resource_prefix }}-lt"
    target_group_arns:
      - "{{ out_tg2.target_group_arn }}"
    desired_capacity: 1
    min_size: 1
    max_size: 1
    state: present
    wait_for_instances: yes
  register: output

- assert:
    that:
      - "output.target_group_arns | length == 1"
      - "output.target_group_arns[0] == out_tg2.target_group_arn"

- name: update autoscaling group remove tg2 and add tg1
  ec2_asg:
    name: "{{ resource_prefix }}-asg"
    launch_template: 
      launch_template_name: "{{ resource_prefix }}-lt"
    target_group_arns:
      - "{{ out_tg1.target_group_arn }}"
    desired_capacity: 1
    min_size: 1
    max_size: 1
    state: present
    wait_for_instances: yes
  register: output

- assert:
    that:
      - "output.target_group_arns | length == 1"
      - "output.target_group_arns[0] == out_tg1.target_group_arn"

[ansibullbot]

cc @garethr @jillr @s-hertel @tremble @wimnat
click here for bot help

[msven]

/rebuild

[msven]

Not sure how to get the tests to re-run - the test failures seem to be issues pulling a docker image.

[tremble]

Test was failing with a linting issue:

06:05 ERROR: tests/integration/targets/ec2_asg/tasks/main.yml:822:7: key-duplicates: duplication of key "register" in mapping (100%)

[tremble]

@jillr any chance you could try the ASG tests locally my connection's currently too flakey for the slow ASG tests.

[tremble]

Changes generally look good, unfortunately I'm not able to run the ASG tests for the next week or two (they're disabled in CI due to their very long duration).

[msven]

ready_for_review

[tremble]

Successfully run the local tests

[tremble]

@msven, many thanks for your submission.

This fix should be available in the next release of this collection (1.5.0)