[Plugin elasticsearch_info] Create a plugin to describe elasticsearch domains #647
Conversation
ansibullbot
added
community_review
module
There was a problem hiding this comment.
In general the code looks good. A couple of minor inline comments.
Additionally,
- please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
- please update the elasticache integration tests to exercise this new module.
| DOCUMENTATION = ''' | ||
| --- | ||
| module: elasticsearch_info | ||
| version_added: 1.6.0 |
There was a problem hiding this comment.
| version_added: 1.6.0 | |
| version_added: 2.0.0 |
It's currently expected that 2.0.0 will be the next release
| ) | ||
|
|
||
| module = AnsibleAWSModule(argument_spec=argument_spec, supports_check_mode=True) | ||
| client = module.client('es') |
There was a problem hiding this comment.
| client = module.client('es') | |
| client = module.client('es', retry_decorator=AWSRetry.jittered_backoff()) |
We also have a decorator which makes it easier to switch out the retry configuration when appropriate. (Often more helpful when modules manipulate resources).
You can then enable the retries on each client call with something like
domain_names = client.list_domain_names(aws_retry=True)['DomainNames']
(aws_retry is optional and defaults to False)
Personally I have a slight preference for the jittered backoff: https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/ but the exponential is fine as is the @ mechanism for enabling them
|
I just re-read your initial comment about not knowing where to find the integration tests: There's a (minimal) integration test for elasticache They're basically just Ansible roles. |
|
(It seems like the ElasticSearch service might be renamed to OpenSearch) (That has not happened yet though) |
ec2_vpc_igw: fix 'NoneType' object is not subscriptable Depends-On: ansible/ansible-zuul-jobs#1368 SUMMARY Add "InternetGatewayAttached" waiter Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Abhijeet Kasurde <None>
`ec2_vpc_igw`: fix NoneType error SUMMARY use paginator for describe internet gateways and add retry_codes='InvalidInternetGatewayID.NotFound' (thanks @alinabuzachis) Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION previously added InternetGatewayAttached waiter but problem still persists (#691) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Jill R <None>
…sible-collections#766) ec2_vpc_igw - dont user filters to paginate to fix NoneType error Depends-On: ansible/ansible-zuul-jobs#1498 SUMMARY Use gateway id when describing gateway instances as opposed to filters if possible to avoid bug of no gateways found. Fixes ansible-collections#647 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None>
|
Thanks for taking the time to submit this PR. It looks like elasticsearch did indeed get renamed to "opensearch". We recently released v4.0.0 of this collection which includes support for managing and describing opensearch clusters. As such I'm going to close out this PR. |
SUMMARY
Introduce a new plugin to describe AWS Elasticsearch domains
ISSUE TYPE
COMPONENT NAME
elasticsearch_info
ADDITIONAL INFORMATION
There is a actually not module to describe Elasticsearch domains so here it is.
I don't know yet how to create and run integration tests on this project so none is included at the moment and I will be more than glad to have some help on this part.