Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_role: replace UpdateRoleDescription with use UpdateRole #697

Merged
merged 3 commits into from Aug 24, 2021
Merged

iam_role: replace UpdateRoleDescription with use UpdateRole #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3446fd
iam_role.py: update update_role_description to update_role
mandar242 Aug 24, 2021
9eea36d
Added changelogs fragment.
mandar242 Aug 24, 2021
2a5a4dd
Update changelogs fragment for better clarity
mandar242 Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/697-iam_role-replace-UpdateRoleDescription-with-UpdateRole.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- iam_role - Modified iam_role internal code to replace update_role_description with update_role (https://github.com/ansible-collections/community.aws/pull/697).
2 changes: 1 addition & 1 deletion plugins/modules/iam_role.py
View file
Open in desktop
Expand Up @@ -327,7 +327,7 @@ def update_role_description(connection, module, params, role):
return True

try:
connection.update_role_description(RoleName=params['RoleName'], Description=params['Description'], aws_retry=True)
connection.update_role(RoleName=params['RoleName'], Description=params['Description'], aws_retry=True)
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
module.fail_json_aws(e, msg="Unable to update description for role {0}".format(params['RoleName']))
return True
Expand Down