Add asg refresh and asg refresh info modules #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce_refreshes_info.py
…stance_refreshes_info modules
There was a problem hiding this comment.
@danquixote Thank you very much for working on this. It really is in Avery good shape. Could you please add check_mode for these modules and expand the tests (combine tasks running with and without check_mode)?
ansibullbot
added
needs_rebase
|
@danquixote this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
|
Hi @danquixote, Thank you so much for contributing on this. Would you be interested in continuing to work on it? Also, while testing out your PR code, I accidentally pushed the fix for merge conflict to your branch, please revert the commit if you wish to do so (I'm also open to collaborating on this PR to take it to completion). |
|
It would be great to have @danquixote's hard work here be merged. @mandar242 would you be able to open a new PR based on this one (create a branch on your own fork of the repo, and open a PR from that) that preserves their commit history so we can get this over the finish line? |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
) ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: #135 PR being revived: #795 Fixes #135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None>
patchback bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
) ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: #135 PR being revived: #795 Fixes #135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 3015013)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
) (#1014) [PR #973/30150139 backport][stable-3] ec2_asg_instance_refresh and ec2_asg_instance_refresh_info modules This is a backport of PR #973 as merged into main (3015013). SUMMARY Reviving original PR that adds Autoscaling instance refresh API support as the author has yet not updated PR based on review feedback. Issue: #135 PR being revived: #795 Fixes #135 ISSUE TYPE New Module Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_instance_refreshes_info ADDITIONAL INFORMATION More about the feature: https://aws.amazon.com/blogs/compute/introducing-instance-refresh-for-ec2-auto-scaling/ Boto3 documentation: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/autoscaling.html#AutoScaling.Client.start_instance_refresh
|
Closed because superseded by #973 |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Deprecate Camel- and Upper- case aliases SUMMARY Clean up aliases. S3_URL is a quirk from the very early code base and wasn't cleaned up when the original cleanup was done (in 2014!) The CamelCase parameters were originally for compatibility. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket aws_s3 ec2_vpc_dhcp_option_info aliases ec2_ami ADDITIONAL INFORMATION S3_URL is causing linting issues with the docs: /home/runner/work/_temp/docsbuild/rst/collections/amazon/aws/aws_s3_module.rst:1478: WARNING: Duplicate explicit target name: "ansible_collections.amazon.aws.aws_s3_module__parameter-s3_url". Reviewed-by: Alina Buzachis <None>
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #135
Resubmitting rebased-PR after initial review on #487 by @tremble .
Overview:
Adding the ec2_asg_instance_refresh and related *_info module. These modules are intended to be used together to start or cancel an EC2 AutoScaling Group (ASG) instance refresh, and then track the subsequent progress with the provided InstanceRefreshId. The *_info module can also be used to get multiple pages of refresh history using the NextToken.
Fixes #487
ISSUE TYPE
COMPONENT NAME
ec2_asg_instance_refresh
ec2_asg_instance_refreshes_info
ADDITIONAL INFORMATION