Add ability to manage resource policy for AWS Secrets Manager secrets #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Added required IAM permissions to the aws-terminator repo, need to trigger retest |
|
Build failed.
|
|
Submitted pull request to add missing IAM permissions to fix failing tests mattclay/aws-terminator#183 |
Added more tests
ykrysko
changed the title
|
Build failed.
|
Relaxed secret resource policy permissions for tests to work from the same account
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Hey @ykrysko I think you've just got the 1 last sanity check failure issue: |
Removed trailing whitespace
|
Build succeeded.
|
|
@marknet15 , thanks! Fixed. |
marknet15
reviewed
Jan 15, 2022
|
@ykrysko just noticed, but you also need to add a changelog fragment |
Added changelog fragment
|
Build succeeded.
|
Thanks, @marknet15 . Added. |
version_added bump
|
Build succeeded.
|
|
Build succeeded.
|
markuman
approved these changes
Jan 24, 2022
alinabuzachis
requested changes
Jan 24, 2022
Added fixes per the review
|
Build failed.
|
|
recheck |
|
Build succeeded.
|
alinabuzachis
approved these changes
Jan 25, 2022
|
Build succeeded (gate pipeline).
|
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
*_info - improve RETURN block of docs Depends-On: ansible-collections#856 SUMMARY Fixes ansible-collections#843 Can things like checking for a period after description be added to our sanity checks? ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ax_info aws_caller_info aws_s3 cloudformation_info ec2_eni_info ec2_group ec2_group_info ec2_instance_info ec2_key ec2_metadata_facts ec2_snapshot_info ec2_spot_instance ec2_spot_instance_info ec2_tag ec2_tag_info ec2_vpc_dhcp_option_info ec2_vpc_endpoint_info ec2_vpc_endpoint_service_info ec2_vpc_igw_info ec2_vpc_nat_gateway ec2_vpc_nat_gateway_info ec2_vpc_net_info ec2_vpc_route_table_info elb_classic_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS Secrets Manager secrets support attaching resource policy. The benefit is huge when necessary to access secrets from other AWS accounts. This pull request adds ability to manage (add new/remove or modify existing) secrets resource policy.
ISSUE TYPE
COMPONENT NAME
module: aws_secret
ADDITIONAL INFORMATION