Fix IOPs io1 DB instance updates and integration tests also #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marknet15
commented
Jan 20, 2022
| tagging | ||
| replica |
There was a problem hiding this comment.
renamed these to ensure we sit in the resource length limits as there was a load of issues on the 3.0.0 release around these limits being hit leading to these tests being disabled.
marknet15
force-pushed
the
rds-iops-fix
branch
from
a8623e6
to
0a9f930
Compare
|
This change depends on a change that failed to merge. |
|
recheck |
|
Build failed.
|
|
recheck |
|
Build failed.
|
marknet15
commented
Jan 22, 2022
tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_sgroups.yml
Show resolved
Hide resolved
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
marknet15
force-pushed
the
rds-iops-fix
branch
from
f31834f
to
2bf8878
Compare
|
Build failed.
|
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
recheck |
marknet15
force-pushed
the
rds-iops-fix
branch
from
25e9753
to
9420993
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
ansibullbot
added
bug
markuman
added
backport-2
markuman
approved these changes
Feb 3, 2022
tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_complex.yml
Outdated
Show resolved
Hide resolved
@alinabuzachis so I checked and |
marknet15
force-pushed
the
rds-iops-fix
branch
from
3ab2947
to
f52ef5b
Compare
|
Build succeeded (third-party-check pipeline).
|
alinabuzachis
approved these changes
Feb 4, 2022
|
Build succeeded (gate pipeline).
|
Backport to stable-2: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 45e79ed on top of patchback/backports/stable-2/45e79ed2e8a60d87b20f77cfbef4ba8a27da1260/pr-878 Backporting merged PR #878 into main
🤖 @patchback |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #927 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
Fix IOPs io1 DB instance updates and integration tests also
SUMMARY
Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing.
Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR.
IOPs error on update attempts if only one param is being updated:
error:
code: InvalidParameterCombination
message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.
type: Sender
msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.'
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
These tests are very slow and still a little flakey but generally all pass as expected now locally.
Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 45e79ed)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Feb 5, 2022
) [PR #878/45e79ed2 backport][stable-3] Fix IOPs io1 DB instance updates and integration tests also This is a backport of PR #878 as merged into main (45e79ed). SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally.
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#878) ec2_group - Add egress_rules and purge_egress_rules aliases SUMMARY Fix ansible-collections#440 - exception running with --diff and --check when creating a new SG by adding a rule referencing a missing SG. Add egress_rules and purge_egress_rules aliases - while cleaning up the tests I kept writing "egress_rules" rather than "rules_egress". Cleanup and re-enable ec2_group tests Remove "Classic Networking" tests (we don't have this in CI and it'll be gone in August) Fix Group/VPC deletion in tests (cross-referenced rules weren't being deleted, wipe the rules first) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_group ADDITIONAL INFORMATION fixes: ansible-collections#440 Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#878) Fix IOPs io1 DB instance updates and integration tests also SUMMARY Primary this PR is to fix updates when updating iops or allocated_storage on io1 DB instances when only one param is changing. Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR. IOPs error on update attempts if only one param is being updated: error: code: InvalidParameterCombination message: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops. type: Sender msg: 'Unable to modify DB instance: An error occurred (InvalidParameterCombination) when calling the ModifyDBInstance operation: You must specify both the storage size and iops when modifying the storage size or iops on a DB instance that has iops.' ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION These tests are very slow and still a little flakey but generally all pass as expected now locally. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@45e79ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Primary this PR is to fix updates when updating
iopsorallocated_storageonio1DB instances when only one param is changing.Secondarily this fixes up the tests again and is test against some improvements to the waiter configuration see linked PR.
IOPs error on update attempts if only one param is being updated:
ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
These tests are very slow and still a little flakey but generally all pass as expected now locally.