x509_crl: prepare releasing the mode option for AnsibleModule's use #596
Conversation
felixfontein
force-pushed
the
x509_crl-mode
branch
from
c14ce10
to
c8fabd3
Compare
|
This fixes the nightly CI failures: https://dev.azure.com/ansible/community.crypto/_build/results?buildId=75691&view=results |
|
Restart CI. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
plugins/modules/x509_crl.py
Outdated
| version_added: 2.13.0 | ||
| mode: | ||
| description: | ||
| - This parameter is deprecated and will be removed in community.crypto 3.0.0. Use I(crl_mode) instead. |
There was a problem hiding this comment.
It looks like this option is the new crl_mode option, as defined in line 45, but it's being set at deprecated with a message to use crl_mode "instead". Am I misreading something?
There was a problem hiding this comment.
Yes; basically I renamed mode to crl_mode, but instead of just adding mode as an alias to crl_mode I have to keep it as a separate option, since otherwise mode as an option would show up from AnsibleModule's add_file_common_args=True.
There was a problem hiding this comment.
How about changing the documentation to:
| - This parameter is deprecated and will be removed in community.crypto 3.0.0. Use I(crl_mode) instead. | |
| - This parameter has been renamed to I(crl_mode). The old name I(mode) is now deprecated and will be removed in community.crypto 3.0.0. | |
| Simply replace usage of this parameter with I(crl_mode). |
There was a problem hiding this comment.
I see my mistake, I completely missed line 59. What had me confused was thinking that 61 was still part of crl_mode 🤦
With that, the old description was fine. The new description is good too; only thing I'd avoid is use of the word "simply" but maybe that's my own feeling only.
There was a problem hiding this comment.
I removed 'simply', see 6666baf.
|
@briantist thanks a lot for reviewing this! |
SUMMARY
Since ansible/ansible#80449 got merged the module no longer works with ansible-core devel, since the
modevaluesgenerateandupdateare not allowed by ansible-core's validation.ISSUE TYPE
COMPONENT NAME
x509_crl