Pass only prefixed attributes to filters

[maxtruxa]

SUMMARY

This PR is mutually exclusive with #103 .

In contrast to the jinja expressions in compose, groups and keyed_groups, filters was given all droplet attributes without a prefix. My bad for not catching that.

Note that this will break anyone who started using this feature since the release of version 1.5.0. If that is a no-go, I can amend the PR to keep the previous inconsistent behavior as well.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

Inventory plugin

ADDITIONAL INFORMATION

Before:

plugin: community.digitalocean.digitalocean
attributes:
  - tags
filters:
  - '"test" in tags'

or even without the attributes:

plugin: community.digitalocean.digitalocean
filters:
  - '"test" in tags'

After:

plugin: community.digitalocean.digitalocean
attributes:
  - tags
filters:
  - '"test" in do_tags'

[codecov]

Codecov Report

Merging #102 (6c000d2) into main (e928762) will increase coverage by 7.98%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   63.75%   71.73%   +7.98%     
==========================================
  Files          30        1      -29     
  Lines        2163       92    -2071     
  Branches      417       17     -400     
==========================================
- Hits         1379       66    -1313     
+ Misses        551       24     -527     
+ Partials      233        2     -231     

Impacted Files	Coverage Δ
plugins/inventory/digitalocean.py	71.73% <100.00%> (+0.14%)	⬆️
plugins/modules/digital_ocean_sshkey.py
plugins/modules/digital_ocean_kubernetes_info.py
plugins/modules/digital_ocean_image_info.py
plugins/modules/digital_ocean_kubernetes.py
plugins/modules/digital_ocean_database.py
plugins/modules/digital_ocean_tag.py
plugins/modules/digital_ocean_floating_ip_info.py
...lugins/modules/digital_ocean_load_balancer_info.py
... and 21 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e928762...6c000d2. Read the comment docs.

[tadeboro]

I think this PR is superior compared to #103 because it preserves the consistency of behavior. And although this is indeed an API break, I would say that the original behavior was flawed, and thus this is a fix that sets things straight. Plus, the Ansible PyPI package did not include the "broken" version of the plugin yet, so not many users were exposed to it.

But this PR does need a documentation fragment that describes the change, this is why I am requesting changes in my review.

[maxtruxa]

@tadeboro Thanks for the feedback! I added the missing changelog fragment.

[mamercad]

Thank you very much for this, want to close #103?

[maxtruxa]

Closed #103. Thank you!