Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize the integration tests #165

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

mamercad
Copy link
Collaborator

SUMMARY

It looks like we're probably running into race conditions with concurrent integration test runs. It's probably a better idea to serialize them, regardless.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

The integration tests.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #165 (8353a6e) into main (403130f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files           1        1           
  Lines          94       94           
  Branches       17       17           
=======================================
  Hits           68       68           
  Misses         24       24           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403130f...8353a6e. Read the comment docs.

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know about this GitHub Action feature.
Thank you for thinking about test stability.

@gundalow
Copy link
Contributor

Integration tests only run on main, so need to merge this PR, then check the GHA results for the default branch (not the PR)

@gundalow gundalow merged commit c881a3a into main Sep 15, 2021
@gundalow gundalow deleted the mamercad/integration-concurrency branch September 15, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants