-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action_group to default vars for every module #281
Conversation
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
===========================================
- Coverage 68.24% 31.19% -37.06%
===========================================
Files 45 45
Lines 3549 3549
Branches 752 752
===========================================
- Hits 2422 1107 -1315
- Misses 801 2423 +1622
+ Partials 326 19 -307
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yep, I'm aware that there are integration failures with the CDN stuff ... just need cycles to dig into them. |
I think all this needs at this point is a changelog fragment ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog fragment please!
I'll provide a fragment, are you otherwise OK with the name ? I also wonder what's the best way to keep an updated list of modules here as they are added and removed from the collection. I came up with this list with a bit of bash-fu but I wonder if there is a better way :p |
This allows, for example, to default the value of oauth_token once without needing to specify it in every task unless it needs to be overridden.
Done ! |
Hehe, I have nothing beyond this: ❯ grep 'module:' plugins/modules/*.py | awk '{print $2}' | sort | uniq
digital_ocean
digital_ocean_account_info
digital_ocean_balance_info
digital_ocean_block_storage
digital_ocean_cdn_endpoints
digital_ocean_cdn_endpoints_info
digital_ocean_certificate
digital_ocean_certificate_info
digital_ocean_database
digital_ocean_database_info
digital_ocean_domain
digital_ocean_domain_info
digital_ocean_domain_record
digital_ocean_domain_record_info
digital_ocean_droplet
digital_ocean_droplet_info
digital_ocean_firewall
digital_ocean_firewall_info
digital_ocean_floating_ip
digital_ocean_floating_ip_info
digital_ocean_image_info
digital_ocean_kubernetes
digital_ocean_kubernetes_info
digital_ocean_load_balancer
digital_ocean_load_balancer_info
digital_ocean_monitoring_alerts
digital_ocean_monitoring_alerts_info
digital_ocean_project
digital_ocean_project_info
digital_ocean_region_info
digital_ocean_size_info
digital_ocean_snapshot
digital_ocean_snapshot_info
digital_ocean_spaces
digital_ocean_spaces_info
digital_ocean_sshkey
digital_ocean_sshkey_info
digital_ocean_tag
digital_ocean_tag_info
digital_ocean_volume_info
digital_ocean_vpc
digital_ocean_vpc_info |
This is a slick feature by the way, thanks for sharing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
SUMMARY
Add an action_group to default vars for every module
This allows, for example, to default the value of oauth_token once
without needing to specify it in every task unless it needs to be
overridden.
ISSUE TYPE
COMPONENT NAME
meta/runtime.yml
ADDITIONAL INFORMATION
Inspired by azure.azcollection's recent fix: ansible-collections/azure#874
Edit: it looks like this for the example in the README: