Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for baseurl parameter in inventory plugin #297

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

gailane
Copy link
Contributor

@gailane gailane commented Dec 28, 2022

SUMMARY

Allows baseurl parameter in the inventory plugin to be changed from the default.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Inventory plugin

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #297 (8e3b9e1) into main (578e9dc) will decrease coverage by 0.61%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   31.70%   31.09%   -0.62%     
==========================================
  Files          45       45              
  Lines        3586     3589       +3     
  Branches      731      732       +1     
==========================================
- Hits         1137     1116      -21     
- Misses       2429     2453      +24     
  Partials       20       20              
Flag Coverage Δ
integration ?
sanity 26.41% <0.00%> (-0.03%) ⬇️
units 64.57% <50.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/inventory/digitalocean.py 71.13% <50.00%> (-1.21%) ⬇️
plugins/modules/digital_ocean_spaces_info.py 47.50% <0.00%> (-40.00%) ⬇️
plugins/modules/digital_ocean_kubernetes_info.py 93.84% <0.00%> (-3.08%) ⬇️
plugins/module_utils/digital_ocean.py 36.09% <0.00%> (-3.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mamercad mamercad merged commit e28cad7 into ansible-collections:main Dec 29, 2022
@gailane gailane deleted the bugfix-inventory-baseurl branch December 29, 2022 21:27
@gailane
Copy link
Contributor Author

gailane commented Dec 29, 2022

Very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants