Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation link for digital_ocean_droplet_info #81

Merged
merged 1 commit into from
May 14, 2021
Merged

Fix documentation link for digital_ocean_droplet_info #81

merged 1 commit into from
May 14, 2021

Conversation

tenshiAMD
Copy link
Contributor

SUMMARY

I've just noticed the incorrect documentation link for digital_ocean_droplet_info while I'm comparing the documentations from ansible galaxy site to this repository.

@tylerauerbeck
Copy link
Contributor

@tenshiAMD Good catch! Looks like your update is now missing the colon though.

README.md Outdated
@@ -25,7 +25,7 @@ Tested with the current Ansible 2.9 and 2.10 releases and the current developmen
- [digital_ocean_domain_info](https://docs.ansible.com/ansible/latest/collections/community/digitalocean/digital_ocean_domain_info_module.html) – Gather information about DigitalOcean Domains
- [digital_ocean_domain_record](https://docs.ansible.com/ansible/latest/collections/community/digitalocean/digital_ocean_domain_record.html) – Create and delete DigitalOcean Domain Records
- [digital_ocean_droplet](https://docs.ansible.com/ansible/latest/collections/community/digitalocean/digital_ocean_droplet_module.html) – Create and delete a DigitalOcean droplet
- [digital_ocean_droplet_info](https;//docs.ansible.com/ansible/latest/collections/community/digitalocean/digital_ocean_droplet_info.html) - Gather information about DigitalOcean Droplets
- [digital_ocean_droplet_info](https//docs.ansible.com/ansible/latest/collections/community/digitalocean/digital_ocean_droplet_info.html) - Gather information about DigitalOcean Droplets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https://

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 😅 I've fixed it @tylerauerbeck, thanks 👍

@mamercad mamercad self-requested a review May 14, 2021 20:46
Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @tylerauerbeck's comment.

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #81 (bbef5d0) into main (50152b7) will decrease coverage by 19.04%.
The diff coverage is n/a.

❗ Current head bbef5d0 differs from pull request most recent head 9f20196. Consider uploading reports for the commit 9f20196 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main      #81       +/-   ##
===========================================
- Coverage   62.32%   43.28%   -19.05%     
===========================================
  Files          30        1       -29     
  Lines        2105       67     -2038     
  Branches      395       11      -384     
===========================================
- Hits         1312       29     -1283     
+ Misses        572       36      -536     
+ Partials      221        2      -219     
Impacted Files Coverage Δ
plugins/modules/digital_ocean_domain.py
plugins/modules/digital_ocean_tag_info.py
plugins/modules/digital_ocean_domain_record.py
plugins/modules/digital_ocean_certificate_info.py
plugins/modules/digital_ocean_droplet.py
plugins/modules/digital_ocean_droplet_info.py
plugins/modules/digital_ocean_snapshot_info.py
plugins/modules/digital_ocean_kubernetes.py
plugins/module_utils/digital_ocean.py
plugins/modules/digital_ocean_sshkey_info.py
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50152b7...9f20196. Read the comment docs.

@tenshiAMD
Copy link
Contributor Author

@mamercad done, thanks 👍

@mamercad
Copy link
Collaborator

@mamercad done, thanks 👍

Thanks for fixing this, it probably wouldn't hurt to add a changelog fragment like this.

I've just noticed the incorrect documentation link for `digital_ocean_droplet_info` while I'm comparing the documentations from ansible galaxy site to this repository.
@tenshiAMD
Copy link
Contributor Author

Thanks for fixing this, it probably wouldn't hurt to add a changelog fragment like this.

@mamercad done with the changelog, thanks 👍

Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@mamercad mamercad merged commit 2f4a69a into ansible-collections:main May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants