Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Droplet integration tests #88

Merged

Conversation

mamercad
Copy link
Collaborator

SUMMARY

Fix Droplet integration tests

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • digital_ocean_droplet

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #88 (9d0f2c9) into main (9ae2532) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   43.28%   43.28%           
=======================================
  Files           1        1           
  Lines          67       67           
  Branches       11       11           
=======================================
  Hits           29       29           
  Misses         36       36           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae2532...9d0f2c9. Read the comment docs.

mpontillo
mpontillo previously approved these changes May 19, 2021
Copy link
Collaborator

@mpontillo mpontillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only suggestion: use time.monotonic() rather than time.time() where possible.

@mamercad
Copy link
Collaborator Author

I pushed my changes to the ci branch, here's the run, it passed.

@mamercad
Copy link
Collaborator Author

recheck

@mpontillo mpontillo self-requested a review May 20, 2021 16:26
Copy link
Collaborator

@mpontillo mpontillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mamercad mamercad merged commit d5bf04b into ansible-collections:main May 20, 2021
@mamercad mamercad deleted the fix-droplet-integration-tests branch June 18, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants