Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait_for_txt: also retrieve IPv6 addresses of nameservers #121

Merged
merged 2 commits into from
Nov 13, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #120.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wait_for_txt
resolver module utils

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #121 (263c47c) into main (a2b30fc) will decrease coverage by 0.37%.
The diff coverage is 94.87%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.42%   96.05%   -0.38%     
==========================================
  Files          83       91       +8     
  Lines        6183     6256      +73     
  Branches      734      734              
==========================================
+ Hits         5962     6009      +47     
- Misses        157      183      +26     
  Partials       64       64              
Flag Coverage Δ
integration ?
sanity 31.45% <15.38%> (?)
units 95.71% <94.87%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/resolver.py 90.85% <84.61%> (-6.78%) ⬇️
tests/unit/plugins/module_utils/test_resolver.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_wait_for_txt.py 100.00% <100.00%> (ø)
plugins/filter/domain_suffix.py 41.66% <0.00%> (-58.34%) ⬇️
plugins/doc_fragments/filters.py 100.00% <0.00%> (ø)
plugins/doc_fragments/module_record_sets.py 100.00% <0.00%> (ø)
plugins/doc_fragments/module_record_info.py 100.00% <0.00%> (ø)
plugins/doc_fragments/module_zone_info.py 100.00% <0.00%> (ø)
plugins/doc_fragments/attributes.py 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein
Copy link
Collaborator Author

@jimkoen did you have a chance to take a look already?

@felixfontein
Copy link
Collaborator Author

Merging as my tests work fine.

@felixfontein felixfontein merged commit 8bdeede into ansible-collections:main Nov 13, 2022
@felixfontein felixfontein deleted the ipv6 branch November 13, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community.dns.wait_for_txt module fails on querying nameservers thart are IPv6 only
1 participant