Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more zone information #38

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

The *_dns_zone_info modules should return more information that the APIs provide.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hetzner_dns_zone_info
hosttech_dns_zone_info

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #38 (730ce05) into main (683a844) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   96.36%   96.38%   +0.01%     
==========================================
  Files          67       67              
  Lines        4792     4812      +20     
  Branches      437      437              
==========================================
+ Hits         4618     4638      +20     
  Misses        123      123              
  Partials       51       51              
Impacted Files Coverage Δ
plugins/module_utils/module/zone_info.py 100.00% <ø> (ø)
plugins/modules/hetzner_dns_zone_info.py 100.00% <ø> (ø)
plugins/modules/hosttech_dns_zone_info.py 100.00% <ø> (ø)
tests/unit/plugins/modules/hosttech.py 83.95% <ø> (ø)
plugins/module_utils/hetzner/api.py 100.00% <100.00%> (ø)
plugins/module_utils/hosttech/json_api.py 99.47% <100.00%> (+<0.01%) ⬆️
plugins/module_utils/hosttech/wsdl_api.py 70.96% <100.00%> (+0.23%) ⬆️
plugins/module_utils/zone.py 100.00% <100.00%> (ø)
tests/unit/plugins/module_utils/test_zone.py 100.00% <100.00%> (ø)
...unit/plugins/modules/test_hetzner_dns_zone_info.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683a844...730ce05. Read the comment docs.

@felixfontein felixfontein merged commit 47dd9d6 into ansible-collections:main Jul 16, 2021
@felixfontein felixfontein deleted the zone-info branch July 16, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant