Skip to content

Commit

Permalink
Replace ansible.module_utils._text by ansible.module_utils.common.tex…
Browse files Browse the repository at this point in the history
…t.converters. (#164)
  • Loading branch information
felixfontein committed Jun 26, 2021
1 parent 825a4f7 commit badcd61
Show file tree
Hide file tree
Showing 29 changed files with 31 additions and 29 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/ansible-core-_text.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- "Avoid internal ansible-core module_utils in favor of equivalent public API available since at least Ansible 2.9 (https://github.com/ansible-collections/community.docker/pull/164)."
2 changes: 1 addition & 1 deletion plugins/connection/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
from ansible.compat import selectors
from ansible.errors import AnsibleError, AnsibleFileNotFound
from ansible.module_utils.six.moves import shlex_quote
from ansible.module_utils._text import to_bytes, to_native, to_text
from ansible.module_utils.common.text.converters import to_bytes, to_native, to_text
from ansible.plugins.connection import ConnectionBase, BUFSIZE
from ansible.utils.display import Display

Expand Down
2 changes: 1 addition & 1 deletion plugins/connection/docker_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
import tarfile

from ansible.errors import AnsibleFileNotFound, AnsibleConnectionFailure
from ansible.module_utils._text import to_bytes, to_native, to_text
from ansible.module_utils.common.text.converters import to_bytes, to_native, to_text
from ansible.plugins.connection import ConnectionBase
from ansible.utils.display import Display

Expand Down
2 changes: 1 addition & 1 deletion plugins/inventory/docker_containers.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
import re

from ansible.errors import AnsibleError
from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native
from ansible.plugins.inventory import BaseInventoryPlugin, Constructable

from ansible_collections.community.docker.plugins.module_utils.common import (
Expand Down
4 changes: 2 additions & 2 deletions plugins/inventory/docker_machine.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@
'''

from ansible.errors import AnsibleError
from ansible.module_utils._text import to_native
from ansible.module_utils._text import to_text
from ansible.module_utils.common.text.converters import to_native
from ansible.module_utils.common.text.converters import to_text
from ansible.module_utils.common.process import get_bin_path
from ansible.plugins.inventory import BaseInventoryPlugin, Constructable, Cacheable
from ansible.utils.display import Display
Expand Down
2 changes: 1 addition & 1 deletion plugins/inventory/docker_swarm.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
'''

from ansible.errors import AnsibleError
from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native
from ansible_collections.community.docker.plugins.module_utils.common import update_tls_hostname, get_connect_params
from ansible.plugins.inventory import BaseInventoryPlugin, Constructable
from ansible.parsing.utils.addresses import parse_address
Expand Down
2 changes: 1 addition & 1 deletion plugins/module_utils/swarm.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# missing Docker SDK for Python handled in ansible.module_utils.docker.common
pass

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native
from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
LooseVersion,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_compose.py
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@
HAS_COMPOSE_EXC = traceback.format_exc()
DEFAULT_TIMEOUT = 10

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
compare_generic,
RequestException,
)
from ansible.module_utils._text import to_native, to_bytes
from ansible.module_utils.common.text.converters import to_native, to_bytes


class ConfigManager(DockerBaseClass):
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_container.py
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@

from ansible.module_utils.common.text.formatters import human_to_bytes
from ansible.module_utils.six import string_types
from ansible.module_utils._text import to_native, to_text
from ansible.module_utils.common.text.converters import to_native, to_text

from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_container_exec.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
import shlex
import traceback

from ansible.module_utils._text import to_text, to_bytes, to_native
from ansible.module_utils.common.text.converters import to_text, to_bytes, to_native

from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_container_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_host_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
DockerBaseClass,
RequestException,
)
from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException, APIError
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
is_valid_tag,
RequestException,
)
from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

if docker_version is not None:
try:
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_image_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker import utils
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_image_load.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
import errno
import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_login.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
import re
import traceback

from ansible.module_utils._text import to_bytes, to_text, to_native
from ansible.module_utils.common.text.converters import to_bytes, to_text, to_native

try:
from docker.errors import DockerException
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@

from distutils.version import LooseVersion

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.common import (
AnsibleDockerClient,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_network_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
RequestException,
)

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.swarm import AnsibleDockerSwarmClient

Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_node_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.common import (
RequestException,
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_prune.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_secret.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
compare_generic,
RequestException,
)
from ansible.module_utils._text import to_native, to_bytes
from ansible.module_utils.common.text.converters import to_native, to_bytes


class SecretManager(DockerBaseClass):
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_swarm.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@

from ansible_collections.community.docker.plugins.module_utils.swarm import AnsibleDockerSwarmClient

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native


class TaskParameters(DockerBaseClass):
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_swarm_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
# missing Docker SDK for Python handled in ansible.module_utils.docker_common
pass

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

from ansible_collections.community.docker.plugins.module_utils.swarm import AnsibleDockerSwarmClient
from ansible_collections.community.docker.plugins.module_utils.common import (
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_swarm_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@

from ansible.module_utils.basic import human_to_bytes
from ansible.module_utils.six import string_types
from ansible.module_utils._text import to_text, to_native
from ansible.module_utils.common.text.converters import to_text, to_native

try:
from docker import types
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_swarm_service_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_volume.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException, APIError
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/docker_volume_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@

import traceback

from ansible.module_utils._text import to_native
from ansible.module_utils.common.text.converters import to_native

try:
from docker.errors import DockerException, NotFound
Expand Down

0 comments on commit badcd61

Please sign in to comment.