docker_compose_v2: allow to pass --build or --no-build to 'docker compose up' #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
felixfontein
merged commit 22d956e
into
ansible-collections:main
122 of 123 checks passed
pgassmann
reviewed
Jan 17, 2024
| - Whether to build images before starting containers. This is used when O(state=present). | ||
| - V(always) always builds before starting containers. This is equivalent to the C(--build) option of C(docker compose up). | ||
| - V(never) never builds before starting containers. This is equivalent to the C(--no-build) option of C(docker compose up). | ||
| - V(policy) uses the policy as defined in the Copose file. |
There was a problem hiding this comment.
Thank you.
Here's a minor typo (Copose).
The description for the build option This is used when O(state=present). is different from the pull option: This is used when C(docker compose up) is ran.
There was a problem hiding this comment.
I'm currently not sure which of the two descriptions is better. Probably the one for pull, since state=stopped can also use docker compose up --no-start to create the containers.
There was a problem hiding this comment.
I'm adjusting it in #766.
Qlas
reviewed
Jan 17, 2024
|
@pgassmann @Qlas thanks, fixed I fixed the typo in c3322fd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ref: #750
Ref: #739 (comment)
ISSUE TYPE
COMPONENT NAME
docker_compose_v2