Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker_image_load module #90

Merged
merged 13 commits into from
Mar 5, 2021

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

First basic, untested version. Fixes #86.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

docker_image_load

@felixfontein
Copy link
Collaborator Author

recheck

@felixfontein
Copy link
Collaborator Author

This PR contains parts of #87, will rebase once that one is merged.

Copy link
Contributor

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I couldn't find anything else but these :)

plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator Author

Restarting tests.

@felixfontein
Copy link
Collaborator Author

First run succeeded, restart tests.

@felixfontein
Copy link
Collaborator Author

Second successful run, restart tests...

@felixfontein
Copy link
Collaborator Author

Third successful run, restarting...

@felixfontein
Copy link
Collaborator Author

Fourth successful run, restarting...

@felixfontein felixfontein reopened this Feb 28, 2021
@felixfontein felixfontein changed the title [WIP] Add docker_image_load module Add docker_image_load module Feb 28, 2021
@felixfontein
Copy link
Collaborator Author

With five successful CI runs in a row, I'm pretty sure that all spurious problems are now gone. (Or seldom enough that they don't matter too much :) )

ready_for_review

@felixfontein
Copy link
Collaborator Author

Restarting tests.

@felixfontein felixfontein reopened this Mar 2, 2021
Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixfontein thanks for the module!

plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
plugins/modules/docker_image_load.py Show resolved Hide resolved
plugins/modules/docker_image_load.py Outdated Show resolved Hide resolved
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@felixfontein
Copy link
Collaborator Author

Hmm, something's wrong with AZP. Restarting tests...

@felixfontein felixfontein reopened this Mar 5, 2021
@felixfontein felixfontein merged commit f142f8c into ansible-collections:main Mar 5, 2021
@felixfontein felixfontein deleted the docker_image_load branch March 5, 2021 08:06
@felixfontein
Copy link
Collaborator Author

@aminvakil @Andersson007 thanks a lot for reviewing this!

@aminvakil
Copy link
Contributor

@felixfontein @Andersson007 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants