Module interfaces_file ignore option line not starting with a space

[olivier-monaco]

Summary

When the module interfaces_file look for options in the interfaces file, it use the following regexp (https://github.com/ansible-collections/community.general/blob/main/plugins/modules/interfaces_file.py#L168):

    patt = re.compile(r'^\s+(?P<option>\S+)\s+(?P<value>\S?.*\S)\s*$')

It required each option line to start with at least one space character (^\s+). The module ignore option lines not starting with space. Modifying this option results in duplicate lines.

To fix this issue, replace + by *:

    patt = re.compile(r'^\s*(?P<option>\S+)\s+(?P<value>\S?.*\S)\s*$')

Issue Type

Bug Report

Component Name

interfaces_file

Ansible Version

ansible [core 2.14.3]
  config file = /home/olivier/xxxxxxx/ansible.cfg
  configured module search path = ['/home/olivier/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.11/dist-packages/ansible
  ansible collection location = /home/olivier/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.11.1 (main, Dec 31 2022, 10:23:59) [GCC 12.2.0] (/usr/bin/python3)
  jinja version = 3.1.2
  libyaml = True

Community.general Version

# /usr/local/lib/python3.11/dist-packages/ansible_collections
Collection        Version
----------------- -------
community.general 6.4.0  

Configuration

No response

OS / Environment

No response

Steps to Reproduce

The task:

- name: Set MTU for eth1
  community.general.interfaces_file:
    iface: "eth1"
    option: mtu
    value: "9000"
    state: present

My interfaces file before:

iface lo inet loopback
auto lo

auto ens192
iface ens192 inet static                                                                                                                                   
address 10.0.0.1
netmask 255.255.255.0
mtu 1500

Expected Results

iface lo inet loopback
auto lo

auto ens192
iface ens192 inet static                                                                                                                                   
address 10.0.0.1
netmask 255.255.255.0
mtu 9000

Actual Results

iface lo inet loopback
auto lo

auto ens192
iface ens192 inet static                                                                                                                                   
address 10.0.0.1
netmask 255.255.255.0
mtu 1500
mtu 9000

Code of Conduct

• I agree to follow the Ansible Code of Conduct

[ansibullbot]

Files identified in the description:

• plugins/modules/interfaces_file.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @hryamzik @obourdon
click here for bot help

[hryamzik]

Oh my, this is exactly why I implemented initial module rewriting C code to python line by line.

Now I think we should revert changes from @russoz in #3328 as they don't add any value but result in issues like this. That's the third one!

I have actually raised my concerns in the review.