Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1082/555eb621 backport][stable-1] solaris_zone: fix zone configuration with python3 #1096

Merged
merged 1 commit into from Oct 15, 2020
Merged

[PR #1082/555eb621 backport][stable-1] solaris_zone: fix zone configuration with python3 #1096

merged 1 commit into from Oct 15, 2020

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 14, 2020

This is a backport of PR #1082 as merged into main (555eb62).

SUMMARY

Fixes #1081 by explicitly opening tempfile.NamedTemporaryFile in text mode and adds a test.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.solaris_zone

ADDITIONAL INFORMATION

N/A

@jbronn
solaris_zone: fix zone configuration with python3 (#1082)
c94c1c6 
* * Explicitly open up temporary file in text mode.
* Add test for `solaris_zone` creation.

* Update changelog fragment.

Co-authored-by: Felix Fontein <felix@fontein.de>

* Add tests for zone deletion and invalid zone names.

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 555eb62)
@ansibullbot
Copy link
Collaborator

cc @MorrisA @bcoca @d-little @fishman @flynn1973 @gforster @jasperla @jpdasma @kairoaraujo @marvin-sinister @mator @molekuul @pmarkham @ramooncamacho @scathatheworm @troy2914 @wtcross @xen0l
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) python3 system tests tests labels Oct 14, 2020
@felixfontein
Copy link
Collaborator

recheck

@felixfontein
Copy link
Collaborator

recheck

1 similar comment
@felixfontein
Copy link
Collaborator

recheck

@felixfontein felixfontein merged commit f9ac30a into stable-1 Oct 15, 2020
@felixfontein felixfontein deleted the patchback/backports/stable-1/555eb62199998fc1640186fede2d68abc4285f71/pr-1082 branch October 15, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module new_contributor Help guide this first time contributor plugins plugin (any type) python3 system tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ansibullbot @felixfontein @jbronn