filesystem.py: fix xfs growfs

[alxgu]

SUMMARY

reopening of ansible/ansible#55646

xfs needs to be mounted to be expanted.

Add function to get mountpoint of filesystem.

• Fail if xfs filesystem is not mounted

xfs growfs needs to be executed on a mountpoint. That will be enforced
now by xfsprogs-4.12.
https://bugzilla.redhat.com/show_bug.cgi?id=1477192

Fixes ansible/ansible#33979

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

filesystem.py

ADDITIONAL INFORMATION

before:

server1| FAILED! => {
    "changed": false,
    "cmd": "/usr/sbin/xfs_growfs -n /dev/vg00/work.tmp",
    "msg": "xfs_growfs: /dev/vg00/work.tmp is not a mounted XFS filesystem",
    "rc": 1,
    "stderr": "xfs_growfs: /dev/vg00/work.tmp is not a mounted XFS filesystem\n",
    "stderr_lines": [
        "xfs_growfs: /dev/vg00/work.tmp is not a mounted XFS filesystem"
    ],
    "stdout": "",
    "stdout_lines": []
}

after:

server1| SUCCESS => {
    "changed": false,
    "msg": "XFS filesystem is using the whole device /dev/vg00/work.tmp"
}

or (when mounted)

server1| SUCCESS => {
    "changed": true,
    "msg": "meta-data=/dev/mapper/vg00-work.tmp isize=512    agcount=4, agsize=32768 blks\n         =                       sectsz=512   attr=2, projid32bit=1\n         =                       crc=1        finobt=1 spinodes=0 rmapbt=0\n         =                       reflink=0\ndata     =                       bsize=4096   blocks=131072, imaxpct=25\n         =                       sunit=0      swidth=0 blks\nnaming   =version 2              bsize=4096   ascii-ci=0 ftype=1\nlog      =internal               bsize=4096   blocks=855, version=2\n         =                       sectsz=512   sunit=0 blks, lazy-count=1\nrealtime =none                   extsz=4096   blocks=0, rtextents=0\ndata blocks changed from 131072 to 134144\n"
}

or (when not mounted)

server1| FAILED! => {
    "changed": false,
    "msg": "/dev/vg00/work.tmp needs to be mounted for xfs operations"
}

[ansibullbot]

cc @MorrisA @abulimov @bcoca @d-little @flynn1973 @gforster @kairoaraujo @marvin-sinister @mator @molekuul @pilou- @ramooncamacho @wtcross
click here for bot help

[felixfontein]

Code looks ok. No idea about functionality itself though (can't test)...

[holdenSK]

Would it be possible to backport this to current 2.9 version as well?

[gundalow]

Could a changelog/fragment file please be added

Would it be possible to backport this to current 2.9 version as well?

@holdenSK Once this has been merged, a backport PR can be raised against ansible/ansible:stable-2.9

[alxgu]

@gundalow A changelog/fragment is included.

[anatolinicolae]

🤔

[gundalow]

@alxgu Thanks for adding the changelog fragment

@anatolinicolae Hi, are you able to checkout this code locally and test it?

@alessiofachechi @kbrowder @larsbu @trammel Hi, I see you commented on ansible/ansible#55646 and ansible/ansible#33979 would you possible be able to review this change so we can get it merged?

[gundalow]

@alxgu @holdenSK @anatolinicolae @larsbu Thank you all for your work in getting this done.

Would it be possible to backport this to current 2.9 version as well?

@alxgu @holdenSK As this has now been merged, if you'd like to see this fixed in Ansible 2.9 please raise a PR directly against github.com/ansible/ansible stable-2.9 branch that references this PR.

[trammel]

@alessiofachechi @kbrowder @larsbu @trammel Hi, I see you commented on ansible/ansible#55646 and ansible/ansible#33979 would you possible be able to review this change so we can get it merged?

I'm sorry, but I don't have the same home lab environment anymore, so I'm not really in a position to test this fix.