json_query: Handle AnsibleUnicode, AnsibleUnsafeText #1434
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
felixfontein
reviewed
Dec 3, 2020
jmespath library does not undestand custom string types such as AnsibleUnicode, and AnsibleUnsafeText. So user need to use ``to_json | from_json`` filter while using functions like ``starts_with`` and ``contains`` etc. This hack will allow user to get rid of this filter. Fixes: ansible-collections#320 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
felixfontein
approved these changes
Dec 4, 2020
|
@Akasurde thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Dec 4, 2020
jmespath library does not undestand custom string types such as AnsibleUnicode, and AnsibleUnsafeText. So user need to use ``to_json | from_json`` filter while using functions like ``starts_with`` and ``contains`` etc. This hack will allow user to get rid of this filter. Fixes: #320 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit 5319437)
felixfontein
pushed a commit
that referenced
this pull request
Dec 4, 2020
jmespath library does not undestand custom string types such as AnsibleUnicode, and AnsibleUnsafeText. So user need to use ``to_json | from_json`` filter while using functions like ``starts_with`` and ``contains`` etc. This hack will allow user to get rid of this filter. Fixes: #320 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> (cherry picked from commit 5319437) Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
jmespath library does not undestand custom string types
such as AnsibleUnicode, and AnsibleUnsafeText.
So user need to use
to_json | from_jsonfilter while usingfunctions like
starts_withandcontainsetc.This hack will allow user to get rid of this filter.
Fixes: #320
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/320_unsafe_text.yml
plugins/filter/json_query.py