New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create vultr_lb module #159

Closed

jstoja wants to merge 2 commits into ansible-collections:master from jstoja:feature/vultr_lb

jstoja commented Apr 13, 2020

SUMMARY

Implement Vultr Load Balancer API (https://www.vultr.com/api/#loadbalancer)

Fixes ansible/ansible#68900

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

vulr_lb

ADDITIONAL INFORMATION

Goal is something like this:

- vultr_lb:
    dcid: 1
    algorithm: Leastconn
    label: web
    state: present
    forwarding_rules:
      - frontend_protocol: https
        frontend_port: 81
        backend_protocol: https
        backend_port: 81


          WIP: Create vultr_lb module

4067f1b

jstoja force-pushed the feature/vultr_lb branch from 82c349c to 4067f1b Compare

April 13, 2020 08:52

Collaborator

felixfontein commented Apr 13, 2020

You need to add a relative symlink from plugins/modules/ to your module.

CC @resmo @Spredzy


          Implement vultr_lb module

75fadb3

jstoja force-pushed the feature/vultr_lb branch from b20e7a5 to 75fadb3 Compare

April 13, 2020 12:47

Author

jstoja commented Apr 13, 2020

I've added the symlink now. Please let me know if you have some feedback, this is my first module.

jstoja changed the title ~~[WIP] Create vultr_lb module~~ Create vultr_lb module

felixfontein reviewed

View reviewed changes

Collaborator

felixfontein left a comment

Some generic comments.

plugins/modules/cloud/vultr/vultr_lb.py

+              DOCUMENTATION = r'''
+              ---
+              module: vultr_lb
+              short_description: Manages Load Balanders on Vultr.

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
            short_description: Manages Load Balanders on Vultr.
          
            short_description: Manages Load Balancers on Vultr

plugins/modules/cloud/vultr/vultr_lb.py

+                dcid:
+                  description:
+                    - DCID integer Location in which to create the load balancer.
+                  required: true

Collaborator

felixfontein Apr 13, 2020

You need to add type: xxx as well. (For all options.)

plugins/modules/cloud/vultr/vultr_lb.py

+                ssl_certificate:
+                  description:
+                    - The SSL Certificate.
+                ssl_chain

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
              ssl_chain
          
              ssl_chain:

plugins/modules/cloud/vultr/vultr_lb.py

+                local_action:
+                  module: vultr_lb
+                  dcid: 1
+                  algorithm: Leastconn

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
                algorithm: Leastconn
          
                balancing_algorithm: leastconn

plugins/modules/cloud/vultr/vultr_lb.py

+              EXAMPLES = r'''
+              - name: Ensure a Load Balancer exists
+                local_action:

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
              local_action:
          
              community.general.vultr_lb:

plugins/modules/cloud/vultr/vultr_lb.py

+              EXAMPLES = r'''
+              - name: Ensure a Load Balancer exists
+                local_action:
+                  module: vultr_lb

Collaborator

felixfontein Apr 13, 2020

Suggested change

module: vultr_lb

plugins/modules/cloud/vultr/vultr_lb.py

+                    - frontend_protocol: https
+                      frontend_port: 81
+                      backend_protocol: https
+                      backend_port: 81

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
                    backend_port: 81
          
                    backend_port: 81
          
              delegate_to: localhost

plugins/modules/cloud/vultr/vultr_lb.py

+              from __future__ import (absolute_import, division, print_function)
+              __metaclass__ = type
+              ANSIBLE_METADATA = {'metadata_version': '0.1',

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
            ANSIBLE_METADATA = {'metadata_version': '0.1',
          
            ANSIBLE_METADATA = {'metadata_version': '1.1',

plugins/modules/cloud/vultr/vultr_lb.py

+                  argument_spec = vultr_argument_spec()
+                  argument_spec.update({
+                      'name': {
+                          'required': True,

Collaborator

felixfontein Apr 13, 2020

Suggested change

      
                        'required': True,
          
                        'type': str,
          
                        'required': True,

You need to specify the type for every option.

plugins/modules/cloud/vultr/vultr_lb.py

+                  module = AnsibleModule(
+                      argument_spec=argument_spec,
+                      required_if=[
+                          ('state', 'present', ['name', 'dcid']),

Collaborator

felixfontein Apr 13, 2020

This doesn't make sense, since you marked both options name and dcid as always required.

sivel mentioned this pull request

Vultr: implement load balancer module ansible/ansible#68900

Closed

Member

resmo commented Apr 13, 2020

We actively maintain the vultr modules in the collection https://github.com/ngine-io/ansible-collection-vultr. The PR for cleanup vultr related content in this repo is currently in the making.

Collaborator

felixfontein commented Apr 13, 2020

See #172.

Author

jstoja commented Apr 13, 2020 via email

No problems :) Would you like me to open the same PR, but on your repository? Otherwise, I’ll close this one.

On 13 Apr 2020, at 17:43, Felix Fontein ***@***.***> wrote: See #172. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Member

resmo commented Apr 13, 2020 •

edited

Loading

No problems :) Would you like me to open the same PR, but on your repository? Otherwise, I’ll close this one.

yes, please create a PR targeting the new repository, feel free to close this PR.

jstoja mentioned this pull request

Feature/vultr lb ngine-io/ansible-collection-vultr#3

Closed

Author

jstoja commented Apr 14, 2020

Closing this one in favor of ngine-io/ansible-collection-vultr#3 .

jstoja closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment