Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: github_repo does not apply defaults on existing repos #2386

Merged
merged 11 commits into from Nov 22, 2021
Merged

Bugfix: github_repo does not apply defaults on existing repos #2386

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
76b53f5
github_repo do not apply defaults on currently existing repos
atorrescogollo Apr 30, 2021
bba2317
Fixed sanity
atorrescogollo Apr 30, 2021
36cf484
Fixed doc defaults
atorrescogollo Apr 30, 2021
c74bf41
Added changelog
atorrescogollo Apr 30, 2021
ad044dc
Fix "or" statement and some formatting
atorrescogollo Apr 30, 2021
5179fd4
Improve description change check
atorrescogollo Apr 30, 2021
772d01a
Added api_url parameter for unit tests and default values for private…
Aug 22, 2021
dd2e326
Added force_defaults parameter
atorrescogollo Nov 14, 2021
cf49581
Improved docs
atorrescogollo Nov 18, 2021
49a5222
Fixed doc anchors for force_defaults parameter
atorrescogollo Nov 18, 2021
d57e154
Update plugins/modules/source_control/github/github_repo.py
atorrescogollo Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions plugins/modules/source_control/github/github_repo.py
View file
Open in desktop
Expand Up @@ -42,14 +42,16 @@
description:
description:
- Description for the repository.
- Defaults to empty when creating a new repository.
- Defaults to empty if force_defaults=true, which is the default in this module.
atorrescogollo marked this conversation as resolved.
Show resolved Hide resolved
- Defaults to empty if force_defaults=false when creating a new repository.
- This is only used when I(state) is C(present).
type: str
required: false
private:
description:
- Whether the repository should be private or not.
- Defaults to C(false) when creating a new repository.
- Defaults to C(false) if force_defaults=true, which is the default in this module.
- Defaults to C(false) if force_defaults=false when creating a new repository.
- This is only used when I(state) is C(present).
type: bool
required: false
Expand All @@ -74,10 +76,11 @@
version_added: "3.5.0"
force_defaults:
description:
- Overwrite current repository attributes with defaults if not set.
- Overwrite current description and private attributes with defaults if not set.
atorrescogollo marked this conversation as resolved.
Show resolved Hide resolved
type: bool
default: true
required: false
atorrescogollo marked this conversation as resolved.
Show resolved Hide resolved
version_added: 4.1.0
requirements:
- PyGithub>=1.54
notes:
Expand Down Expand Up @@ -206,8 +209,8 @@ def delete_repo(gh, name, organization=None, check_mode=False):

def run_module(params, check_mode=False):
if params['force_defaults']:
params['description'] = params.get('description') or ''
params['private'] = params.get('private') or False
params['description'] = params['description'] or ''
params['private'] = params['private'] or False

gh = authenticate(
username=params['username'], password=params['password'], access_token=params['access_token'],
Expand Down