Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module sapcar_extract to make SAP administration easier. #2596

Merged
merged 25 commits into from Jun 4, 2021
Merged

Add module sapcar_extract to make SAP administration easier. #2596

merged 25 commits into from Jun 4, 2021

Conversation

rainerleber
Copy link
Contributor

SUMMARY

sapcar_extract - This module uses the properitary SAPCAR binary to extract SAR/CAR Files
The sapcar_extract module adds the abillity for idempotence for unpacking SAP files.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

sapcar_extract

@rainerleber
Copy link
Contributor Author

reopened PR sry for the mess

@ansibullbot ansibullbot added affects_2.10 community_review files module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_module New module new_plugin New plugin plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging labels May 23, 2021
@ansibullbot ansibullbot added tests tests unit tests/unit labels May 23, 2021
@rainerleber
Copy link
Contributor Author

SAPCAR (older version was called CAR) is a compress utility (similar to winzip, tar, zip, gz, etc.) , that is used by SAP to compress and decompress nearly all delivered files and executables.

@rainerleber
Copy link
Contributor Author

@Andersson007 @felixfontein could you please review this pr :-)

@felixfontein
Copy link
Collaborator

@rainerleber I'll try to find time over the weekend!

@Andersson007
Copy link
Contributor

@rainerleber I'll try to make time for this during the week, thanks

@Andersson007
Copy link
Contributor

@felixfontein @Andersson007 thank you for reviewing. You are such great guys :-D

@rainerleber you could also become a great reviewer (at least to pre-review your future works and I hope for others' works as well) by using this Review checklist:)

@rainerleber @Andersson007
Apply suggestions from code review
5fe4a25 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Andersson007
Andersson007 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig in the code. From general perspective LGTM

felixfontein
felixfontein reviewed Jun 1, 2021
View reviewed changes
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
rainerleber and others added 3 commits June 2, 2021 08:51
@rainerleber @felixfontein
Apply suggestions from code review
f29115c 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber
cleanup and fixes
b7395ff
@rainerleber
sanity
a062aa3
felixfontein
felixfontein reviewed Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits, then it's ready I think :)

plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
plugins/modules/files/sapcar_extract.py Outdated Show resolved Hide resolved
@rainerleber @felixfontein
Apply suggestions from code review
f2630b5 
Co-authored-by: Felix Fontein <felix@fontein.de>
@rainerleber
Copy link
Contributor Author

Thank you for reviewing and your time :-)

@Andersson007
Copy link
Contributor

@rainerleber thanks for the module!

@felixfontein felixfontein merged commit a4f46b8 into ansible-collections:main Jun 4, 2021
@felixfontein
Copy link
Collaborator

@rainerleber thanks for contributing this!
@Andersson007 thanks for reviewing!

@patchback
Copy link

patchback bot commented Jun 4, 2021 •
edited

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/a4f46b881ac4596ff32e8581df4c794301dacd6e/pr-2596

Backported as #2705

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 4, 2021
@rainerleber
Add module sapcar_extract to make SAP administration easier. (#2596)
58c6fd2 
* add sapcar

* integrate test

* test integration

* Revert "integrate test"

This reverts commit 17cbff4.

* add requiered

* change test

* change binary

* test

* add bin bath

* change future

* change download logic

* change logic

* sanity

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* add url and error handling

* sanity

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* cleanup and fixes

* sanity

* add sec library

* add description

* remove blanks

* sanity

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Rainer Leber <rainer.leber@sva.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit a4f46b8)
@patchback patchback bot mentioned this pull request Jun 4, 2021
Merged
felixfontein pushed a commit that referenced this pull request Jun 4, 2021
@patchback @rainerleber
Add module sapcar_extract to make SAP administration easier. (#2596) (#…
6549e41 
…2705)

* add sapcar

* integrate test

* test integration

* Revert "integrate test"

This reverts commit 17cbff4.

* add requiered

* change test

* change binary

* test

* add bin bath

* change future

* change download logic

* change logic

* sanity

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* add url and error handling

* sanity

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* cleanup and fixes

* sanity

* add sec library

* add description

* remove blanks

* sanity

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Rainer Leber <rainer.leber@sva.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
(cherry picked from commit a4f46b8)

Co-authored-by: rainerleber <39616583+rainerleber@users.noreply.github.com>
@Andersson007
Copy link
Contributor

@felixfontein thanks for the thorough review! I should train ansible_reviewer to identify the camel-like notation:))

@rainerleber thanks for working on this:)

@rainerleber rainerleber deleted the module_sapcar_extract branch June 6, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
community_review files module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage new_module New module new_plugin New plugin plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rainerleber @felixfontein @Andersson007 @ansibullbot