Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inventory and vault scripts #2696

Merged
merged 2 commits into from
Jun 19, 2021
Merged

Remove inventory and vault scripts #2696

merged 2 commits into from
Jun 19, 2021

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Jun 3, 2021 •
edited
Loading

SUMMARY

Will be merged once the docsite is updated to no longer reference the files from this repo.

Closes ansible-community/community-topics#16.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

inventory and vault scripts

@felixfontein felixfontein mentioned this pull request Jun 3, 2021
Closed
@ansibullbot
Copy link
Collaborator

@felixfontein This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@ansibullbot ansibullbot added WIP Work in progress affects_2.10 docs has_issue needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage labels Jun 3, 2021
@felixfontein felixfontein added breaking_change This PR contains a breaking change that MUST NOT be backported check-before-release PR will be looked at again shortly before release and merged if possible. and removed affects_2.10 labels Jun 3, 2021
@felixfontein felixfontein mentioned this pull request Jun 3, 2021
Closed
@felixfontein
Copy link
Collaborator Author

Backports of doc change are ansible/ansible#74926 and ansible/ansible#74927.

@felixfontein felixfontein changed the title [WIP] Remove inventory and vault scripts Remove inventory and vault scripts Jun 10, 2021
@felixfontein
Copy link
Collaborator Author

I plan to merge this by the end of next week.

@ansibullbot ansibullbot added community_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed WIP Work in progress labels Jun 10, 2021
@felixfontein
Copy link
Collaborator Author

And now the end has come. Bye bye, scripts... 👋

@felixfontein felixfontein merged commit 08f7ad0 into ansible-collections:main Jun 19, 2021
@felixfontein felixfontein deleted the remove-scripts branch June 19, 2021 13:07
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jun 19, 2021
@Andersson007
Copy link
Contributor

Thanks for the great purge!

kristianheljas added a commit to kristianheljas/ansible that referenced this pull request Jan 18, 2023
@kristianheljas
Fix broken link for inventory script examples
30d51d3 
These scripts were removed from community.general in ansible-collections/community.general#2696 and moved to ansible-community/contrib-scripts per ansible-community/community-topics#16 (comment)
@kristianheljas kristianheljas mentioned this pull request Jan 18, 2023
Merged
samccann pushed a commit to ansible/ansible that referenced this pull request Jan 19, 2023
@kristianheljas
Fix broken link for inventory script examples (#79762)
97993ee 
These scripts were removed from community.general in ansible-collections/community.general#2696 and moved to ansible-community/contrib-scripts per ansible-community/community-topics#16 (comment)
samccann pushed a commit to samccann/ansible that referenced this pull request Jan 19, 2023
@kristianheljas @samccann
Fix broken link for inventory script examples (ansible#79762)
930ec3c 
These scripts were removed from community.general in ansible-collections/community.general#2696 and moved to ansible-community/contrib-scripts per ansible-community/community-topics#16 (comment)

(cherry picked from commit 97993ee)
nitzmahone pushed a commit to ansible/ansible that referenced this pull request Jan 19, 2023
@samccann @iamgini
@KristopherKram @evangelionlion @dericcrago @Andersson007 @runejuhl @kristianheljas @Hofer-Julian @antonc42 @kenyon @mattclay
Backportapalooza 01 19 (#79771)
a7aeb61 
* Update authentication.rst (#79623)

(cherry picked from commit e7af753)

* Fix typo (#79641)

(cherry picked from commit 8e7cc37)

* correct the mistake of example repeat_original (#79659)

there is a little mistake

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

(cherry picked from commit 6f8c1da)

* switched reference from katacoda to instruqt (#79698)

(cherry picked from commit 0fc932f)

* contributor_path: fix typos (#79678)

(cherry picked from commit fe7d488)

* Fix broken reference to FAQ (#79621)

(cherry picked from commit 602824d)

* Docsite: add Security Automation Working Group to Communication guide (#79692)

(cherry picked from commit 65efa4b)

* Docsite: remove dead Lockdown Working Group from Communication guide (#79693)

(cherry picked from commit 55f9d7f)

* Fix `undef()` example to a valid Jinja template (#79701)

(cherry picked from commit e41d287)

* Truthy value should be one of false or true (#79730)

Otherwise ansible-lint complains: https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.truthy

(cherry picked from commit b756a08)

* Fix regex filter docs (#79736)

* Fix notes in regex_replace doc

The documentation says that this maps to 'regex.replace' when it should say 're.replace'. The distinction is important because of the third-party 'regex' module that has more features than the built-in 're' module. https://pypi.org/project/regex/

* Fix notes in re.search docs

The documentation says that this maps to 'regex.search' when it should say 're.search'. The distinction is important because of the third-party 'regex' module that has more features than the built-in 're' module. https://pypi.org/project/regex/

(cherry picked from commit cf50d81)

* complex_data_manipulation.rst: fix typo (#79758)

(cherry picked from commit b5b7f9b)

* Fix broken link for inventory script examples (#79762)

These scripts were removed from community.general in ansible-collections/community.general#2696 and moved to ansible-community/contrib-scripts per ansible-community/community-topics#16 (comment)

(cherry picked from commit 97993ee)

* communication.rst: improve (#79751)

(cherry picked from commit 11a27ee)

* Fix broken docs links. (#79769)

(cherry picked from commit 5d71ace)

Co-authored-by: Gineesh Madapparambath <net.gini@gmail.com>
Co-authored-by: Kristopher Henry Kram <kristopher@kristopherkram.com>
Co-authored-by: evangelionlion <546620084@qq.com>
Co-authored-by: Deric Crago <deric.crago@gmail.com>
Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
Co-authored-by: Rune Juhl Jacobsen <rune@juhljacobsen.dk>
Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com>
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
Co-authored-by: antonc42 <antonc42@users.noreply.github.com>
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
Co-authored-by: Matt Clay <matt@mystile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported community_review docs has_issue needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What to do with inventory and vault scripts in community.general?
3 participants
@felixfontein @ansibullbot @Andersson007