open-iscsi: adding mutual authentication support and updating authentication parameters description #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… authentication credentials
ansibullbot
added
feature
|
The test The test The test The test The test The test The test The test |
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
ricsanfre
changed the title
Ajpantuso
requested changes
Sep 23, 2021
There was a problem hiding this comment.
Thanks for your contribution! Please add a changelog fragment as well.
ansibullbot
added
the
needs_revision
felixfontein
added
backport-3
check-before-release
Adding version_added to node_user_in parameter Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
adding version_added attibute to new parameter password_in Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
ansibullbot
added
needs_ci
|
The test The test The test |
ansibullbot
added
ci_verified
…-iscsi-mutual-authentication-support.yaml
ansibullbot
added
needs_ci
ansibullbot
added
needs_revision
Ajpantuso
requested changes
Sep 24, 2021
changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml
Outdated
Show resolved
Hide resolved
…port.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
Ajpantuso
requested changes
Sep 25, 2021
changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml
Outdated
Show resolved
Hide resolved
…port.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com>
ansibullbot
removed
the
needs_revision
felixfontein
removed
the
check-before-release
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #3447 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 26, 2021
…ication parameters description (#3422) * Adding mutual athentication support and changing doucumentation about authentication credentials * Removing blank line with whitspaces * Update plugins/modules/system/open_iscsi.py Adding version_added to node_user_in parameter Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update plugins/modules/system/open_iscsi.py adding version_added attibute to new parameter password_in Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update plugins/modules/system/open_iscsi.py Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Adding changelog fragment for #3422 * Rename 3422-open-iscsi-mutual-authentication-support.yam to 3422-open-iscsi-mutual-authentication-support.yaml * Update changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com> Co-authored-by: Ajpantuso <ajpantuso@gmail.com> (cherry picked from commit 43a9f09)
|
@ricsanfre thanks for implementing this! |
felixfontein
pushed a commit
that referenced
this pull request
Sep 26, 2021
…ication parameters description (#3422) (#3447) * Adding mutual athentication support and changing doucumentation about authentication credentials * Removing blank line with whitspaces * Update plugins/modules/system/open_iscsi.py Adding version_added to node_user_in parameter Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update plugins/modules/system/open_iscsi.py adding version_added attibute to new parameter password_in Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update plugins/modules/system/open_iscsi.py Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Adding changelog fragment for #3422 * Rename 3422-open-iscsi-mutual-authentication-support.yam to 3422-open-iscsi-mutual-authentication-support.yaml * Update changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update changelogs/fragments/3422-open-iscsi-mutual-authentication-support.yaml Co-authored-by: Ajpantuso <ajpantuso@gmail.com> Co-authored-by: Ajpantuso <ajpantuso@gmail.com> (cherry picked from commit 43a9f09) Co-authored-by: Ricardo Sanchez <84853324+ricsanfre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updating confusing description of authentication parameters included in documentation section
and adding the capability to specify mutual authentication between target and initiator
ISSUE TYPE
COMPONENT NAME
plugins/modules/system/open_iscsi.py
ADDITIONAL INFORMATION
node_auth, node_pass and node_user parameters are used for target login, not for target discovery. Authentication can be set for both procedures (discovery and login) but module current implementation does not support discovery authentication and thus parameters descriptions are confusing.
Adding two new module parameters (node_user_in, node_pass_in) to support mutual authentication.