Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3726/946430e1 backport][stable-3] terraform: ensuring command options are applied during build_plan #3777

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Nov 23, 2021

This is a backport of PR #3726 as merged into main (946430e).

SUMMARY

Fixes: 3707

State: Planned does not use other command options such as lock: true or lock_timeout: 10
This proposed change includes all command options in planning stage to ensure no options are missed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

terraform.py

ADDITIONAL INFORMATION

To reproduce this issue:

  • Set Terraform module with State: plan
  • Set lock_timout
  • Run the task on a already locked state file
  • It will not wait for the lock to be removed and fail directly

)

* Fixes parameters missing in planned state

* Added new line at end of file

* Added changelog fragment for pr 3726

* Added changes mentioned by felixfontein

* Removed blank space for pep8 validation

* Update changelogs/fragments/3726-terraform-missing-parameters-planned-fix.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/cloud/misc/terraform.py

extend needs to be a list

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Thomas Arringe <thomas.arringe@fouredge.se>
Co-authored-by: Thomas Arringe <Thomas.Arringe@ica.se>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 946430e)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug cloud module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 23, 2021
@felixfontein felixfontein merged commit 53e0bf8 into stable-3 Nov 23, 2021
@felixfontein felixfontein deleted the patchback/backports/stable-3/946430e1fbd54d6abfa3105304bd651272a544c3/pr-3726 branch November 23, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug cloud module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants