terraform module: Added backend_config_file and multiple variables_file

[m-yosefpor]

SUMMARY

This PR adds support for multiple variables_file for "terraform" module, Fixes #224 issue. Moreover, this adds support for "backend_config_file" to provide at init state to the -backend-config parameter. This can accept a list of paths to multiple configuration files.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

terraform module

ADDITIONAL INFORMATION

It is possible to pass multiple var-files in terraform cli:

terraform apply -var-file="file-1.tfvars" -var-file="file-2.tfvars" -var-file="file-3.tfvars"

This is required when there are multiple var-files in different locations.

Also the "-backend-config" parameter, accepts both "key=value" type and "PATH" type. This parameter can also be passed multiple backend config files:

terraform init -backend-config=path/to/backend_config_file_1 -backend-config=path/to/backend_config_file_2

[ansibullbot]

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

plugins/modules/cloud/misc/terraform.py:287:43: bad-whitespace: Exactly one space required after comma             variables_file=dict(type='list',default=None),                                            ^
plugins/modules/cloud/misc/terraform.py:320:61: bad-whitespace: Exactly one space required after comma         init_plugins(command[0], project_path, backend_config,backend_config_file)                                                              ^

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

plugins/modules/cloud/misc/terraform.py:100:161: E501: line too long (165 > 160 characters)
plugins/modules/cloud/misc/terraform.py:287:44: E231: missing whitespace after ','
plugins/modules/cloud/misc/terraform.py:320:62: E231: missing whitespace after ','
plugins/modules/cloud/misc/terraform.py:342:11: E111: indentation is not a multiple of four

click here for bot help

[m-yosefpor]

zuul fails with:

'ERROR! module community.general.intersight_info missing documentation

hmm.. so what should I do? It has nothing to do with my change! I think it is probably related to this latest commit : 7bb36d6

[felixfontein]

You need a changelog fragment.

[felixfontein]

You can ignore the failing Zuul tests for now.

[ansibullbot]

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/cloud/misc/terraform.py:0:0: doc-elements-mismatch: Argument 'variables_file' in argument_spec specifies elements as path,but elements is not documented

click here for bot help

[felixfontein]

Looks good to me. I don't know terraform though, so no idea whether this change works as expected and makes sense.

[m-yosefpor]

File: A configuration file may be specified via the init command line. To specify a file, use the -backend-config=PATH option when running terraform init.

If backend settings are provided in multiple locations, the top-level settings are merged such that any command-line options override the settings in the main configuration and then the command-line options are processed in order, with later options overriding values set by earlier options.

https://www.terraform.io/docs/backends/config.html#partial-configuration

I have actually tested the module locally.

BTW, Thanks Felix, you helped a lot. I've got familiar with how to create appropriate PRs for ansible modules (changelogs, sanity checks, etc). Future contributions are on the way :)

[m-yosefpor]

ERROR! module community.general.kubevirt_pvc missing documentation

[felixfontein]

That's the error in Zuul. The problem is that in the Zuul tests, the collection dependencies of community.general are not installed. Simply ignore the Zuul tests for now, right now they are not helpful at all. (On Shippable the same tests runs fine, because the dependencies are installed.)

[m-yosefpor]

Aha. Ok, so what is the next step? Do I need to take extra steps for this PR to be merged?

[felixfontein]

@m-yosefpor you need to find someone to review/test this who actually uses terraform. Maybe look at issues/PRs for terraform in this repo, there seem to be other people also interested in this module.

[m-yosefpor]

@Andersson007 I wonder if you are the one person to review this PR. You are the only one who has committed regarding terraform.py. (and an infra engineer). Thank you in advanced.

[Andersson007]

@m-yosefpor hey, unfortunately i don't use terraform. We need somebody who can try this without learning the tool from scratch

[Andersson007]

CC @ryansb as the module's author could you please look at the changes? I'll text you by mail as well

[felixfontein]

@Andersson007 Ryan used to work for Ansible, and switched jobs some time ago, so I'm not sure whether he's still interested. Especially since he is in the ignore BOTMETA list for cloud/misc/.

[felixfontein]

@effaamponsah @FrancisBilla you both created a PRs for the terraform module recently, so apparently you're also interested in it.

[Andersson007]

@felixfontein ah, thanks for the info

[FrancisBilla]

@effaamponsah @FrancisBilla you both created a PRs for the terraform module recently, so apparently you're also interested in it.

yeah!!!

[Andersson007]

@FrancisBilla if the changes are ok for you, please, approve the PR and we'll merge it

[m-yosefpor]

Does stale_ci label need any action from me?

[Andersson007]

Does stale_ci label need any action from me?

no

[Andersson007]

i've just relaunched the tests to get rid of the label

[FrancisBilla]

@FrancisBilla if the changes are ok for you, please, approve the PR and we'll merge it

Looks good for me, @felixfontein and his team are in charge

[Andersson007]

@m-yosefpor thanks for the contribution!
@felixfontein @FrancisBilla thanks for reviewing!

[Andersson007]

merged #394 into master

[m-yosefpor]

@m-yosefpor thanks for the contribution!
@felixfontein @FrancisBilla thanks for reviewing!

thank you too, for your welcoming community.. more one the way ;)