Bug fix: Warns user if incorrect SDK version is installed #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Can you add a changelog fragment? Thanks.
felixfontein
added
check-before-release
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
Added. Also changed the bare exception as suggested. Thanks for the review. |
changelogs/fragments/4422-warn-user-if-incorrect-SDK-version-is-installed.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Apr 5, 2022
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #4449 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Add error handling to check correct SDK version installed * Fix CI errors * Added changelog fragment * Changed exeption type * Update changelogs fragment Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e7ffa76)
|
@EndlessTrax thanks for fixing this! |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4450 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Add error handling to check correct SDK version installed * Fix CI errors * Added changelog fragment * Changed exeption type * Update changelogs fragment Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e7ffa76)
felixfontein
pushed a commit
that referenced
this pull request
Apr 5, 2022
) * Add error handling to check correct SDK version installed * Fix CI errors * Added changelog fragment * Changed exeption type * Update changelogs fragment Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e7ffa76) Co-authored-by: Ricky White <rickywhite@outlook.com>
felixfontein
pushed a commit
that referenced
this pull request
Apr 5, 2022
) * Add error handling to check correct SDK version installed * Fix CI errors * Added changelog fragment * Changed exeption type * Update changelogs fragment Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit e7ffa76) Co-authored-by: Ricky White <rickywhite@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This raises an error if the wrong
python-dsv-sdkversion is installed. This lookup plugin currently only supports v0.0.1 of the SDK. This is a temporary fix until full support with the latest SDK version can be developed.(Re-submitted with clean git history)
ISSUE TYPE
COMPONENT NAME
dsv lookup plugin
ADDITIONAL INFORMATION
Before the fix, the error presented to the user:
After: