[PR #4421/bbe231e2 backport][stable-4] Bugfix: zypper issue with specified package versions

[patchback]

This is a backport of PR #4421 as merged into main (bbe231e).

zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list.

SUMMARY

I added an empty check to prevent get_installed_state() being called with an empty package list.

Fixes ##4371

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

zypper

ADDITIONAL INFORMATION

The following task ALWAYS reported [ok] if ANY version of a-very-important-package was already installed on the target system.

    - name: Install a specific package version via zypper
      zypper:
        name:
          - "a-very-important-package=2.1"
        state: present
        oldpackage : yes

As soon as at least ONE other package WITHOUT a version specification was requestet, everything worked as expected.

    - name: Install a specific package version via zypper
      zypper:
        name:
          - "a-very-important-package=2.1"
          - "another-package"
        state: present
        oldpackage : yes

after my fix, that workaroud is not necessary and both of the above work as expected

[ansibullbot]

cc @AnderEnder @alxgu @andytom @commel @dcermak @evrardjp @lrupp @sealor @toabctl
click here for bot help