Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4567/3b103f90 backport][stable-4] Removed 'default=None' in a batch of modules 2 #4569

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 24, 2022

This is a backport of PR #4567 as merged into main (3b103f9).

SUMMARY

Removed the redundant default=None from a batch of modules. Plus a few adjacent required=False.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/cloud/atomic/atomic_container.py
plugins/modules/cloud/misc/proxmox.py
plugins/modules/cloud/packet/packet_device.py
plugins/modules/cloud/packet/packet_sshkey.py
plugins/modules/cloud/packet/packet_volume.py
plugins/modules/cloud/profitbricks/profitbricks.py
plugins/modules/cloud/smartos/smartos_image_info.py
plugins/modules/cloud/smartos/vmadm.py
plugins/modules/cloud/webfaction/webfaction_app.py
plugins/modules/cloud/webfaction/webfaction_db.py
plugins/modules/clustering/nomad/nomad_job.py
plugins/modules/clustering/nomad/nomad_job_info.py

* removed default=None

* added changelog fragment

(cherry picked from commit 3b103f9)
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug cloud clustering module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 24, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #4569 (3b103f9) into stable-4 (d53052f) will increase coverage by 1.26%.
The diff coverage is 0.00%.

❗ Current head 3b103f9 differs from pull request most recent head 580fafb. Consider uploading reports for the commit 580fafb to get more accurate results

@@             Coverage Diff              @@
##           stable-4    #4569      +/-   ##
============================================
+ Coverage     43.56%   44.83%   +1.26%     
============================================
  Files           926      951      +25     
  Lines         90108    93605    +3497     
  Branches      16522    17873    +1351     
============================================
+ Hits          39259    41970    +2711     
- Misses        49103    49696     +593     
- Partials       1746     1939     +193     
Flag Coverage Δ
integration 71.06% <ø> (-0.91%) ⬇️
sanity 21.25% <ø> (-0.11%) ⬇️
stub 0.00% <0.00%> (ø)
units 67.50% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.azure-pipelines/scripts/publish-codecov.py 0.00% <0.00%> (ø)
plugins/module_utils/mh/deco.py 67.74% <0.00%> (-26.86%) ⬇️
...ugins/modules/remote_management/ipmi/ipmi_power.py 26.02% <0.00%> (-17.57%) ⬇️
plugins/callback/syslog_json.py 43.39% <0.00%> (-14.11%) ⬇️
plugins/inventory/linode.py 35.71% <0.00%> (-11.41%) ⬇️
plugins/module_utils/proxmox.py 44.30% <0.00%> (-10.46%) ⬇️
plugins/filter/list.py 86.88% <0.00%> (-9.12%) ⬇️
...les/source_control/gitlab/gitlab_group_variable.py 18.78% <0.00%> (-8.65%) ⬇️
plugins/lookup/dsv.py 71.79% <0.00%> (-8.21%) ⬇️
...s/source_control/gitlab/gitlab_project_variable.py 19.33% <0.00%> (-8.02%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e5a0d...580fafb. Read the comment docs.

@felixfontein felixfontein merged commit e933ed7 into stable-4 Apr 24, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/3b103f905ec73c1d4f6750112a6dd19ed0e0d475/pr-4567 branch April 24, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug cloud clustering module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants