nmcli - Use 'connection.autoconnect' instead of 'autoconnect'

[Akasurde]

SUMMARY

Correct usage of autoconnect in nmcli module.

Fixes: #459

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

changelogs/fragments/63609_nmcli.yml
plugins/modules/net_tools/nmcli.py

[ansibullbot]

cc @alcamie101 @nerzhul
click here for bot help

[gundalow]

@Akasurde Would you be able to rebase and address the above review comments, we can review this during PR day later today

[felixfontein]

Changelog looks good. Can't judge the change...

[mator]

tested on centos-7 without and with patch applied, works in both cases... going to test on ubuntu 16.x as well...

[Andersson007]

@mator didn't you try on ubuntu 16.x yet? thanks!

[mator]

i'm unable to reproduce on ubuntu 16.04 , works (without any additional patches) on latest git version of ansible (and tag v2.9.9) and C.G. :

ubuntu version:

root@ubuntu1604:~# cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04.7 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.7 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

ansible environment (tested both versions of ansible, latest git and tag v2.9.9) :

[mator@archlinux ansible.dev]$ ansible --version
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features
under development. This is a rapidly changing source of code and can become unstable at any point.
ansible 2.11.0.dev0 (devel c20329a0f6) last updated 2020/10/21 14:07:52 (GMT +300)
  config file = /home/mator/ansible.dev/ansible.cfg
  configured module search path = ['/home/mator/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/mator/ansible.dev/ansible/lib/ansible
  ansible collection location = /home/mator/ansible.dev/collections
  executable location = /home/mator/ansible.dev/ansible/bin/ansible
  python version = 3.8.6 (default, Sep 30 2020, 04:00:38) [GCC 10.2.0]
  libyaml = True

$ cd community.general.git
[mator@archlinux community.general.git]$ git desc
0.1.4-260-g7caba156

playbook (tested with type generic and ethernet)

$ cat playbooks/nmcli.yml
---
- name: community.general/issues/459
  hosts: ubuntu1604
  become: true
  gather_facts: false
  tasks:
  - name: 'Use the nmcli module with default parameters'
    nmcli:
      conn_name: 'testcon1'
      type: 'generic'
      state: 'present'

before running playbook :

root@ubuntu1604:~# nmcli con show
NAME  UUID  TYPE  DEVICE
root@ubuntu1604:~#

playbook run:

$ ansible-playbook playbooks/nmcli.yml
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features
under development. This is a rapidly changing source of code and can become unstable at any point.

PLAY [community.general/issues/459] *************************************************************************************************************************************

TASK [Use the nmcli module with default parameters] *********************************************************************************************************************
changed: [ubuntu1604]

PLAY RECAP **************************************************************************************************************************************************************
ubuntu1604                 : ok=1    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

root@ubuntu1604:~# nmcli con show
NAME      UUID                                  TYPE     DEVICE
testcon1  9c3d1877-f518-44dd-9823-1d9f288d8775  generic  --

[Andersson007]

@mator thanks for testing! So the patch doesn't fix anything?

[aminvakil]

I guess this has been fixed in #1113.

community.general/plugins/modules/net_tools/nmcli.py

Lines 634 to 638 in 1db167b

	def connection_options(self, detect_change=False):
	# Options common to multiple connection types.
	options = {
	'connection.autoconnect': self.autoconnect,
	}

[dmsimard]

@aminvakil thanks !