Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfconf: add unit test for bool value #5014

Merged

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jul 27, 2022

SUMMARY

Added additional test to prevent #4999 from happening again.

ISSUE TYPE
  • Feature Pull Request

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request tests tests unit tests/unit labels Jul 27, 2022
@felixfontein felixfontein merged commit 1c167ab into ansible-collections:main Jul 28, 2022
@patchback
Copy link

patchback bot commented Jul 28, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/1c167ab8948afe429fd4591ea4434f14ab40a862/pr-5014

Backported as #5017

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 28, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks for adding this test!

@patchback
Copy link

patchback bot commented Jul 28, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/1c167ab8948afe429fd4591ea4434f14ab40a862/pr-5014

Backported as #5018

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 28, 2022
@russoz russoz deleted the xfconf-add-bool-test branch July 28, 2022 11:06
felixfontein pushed a commit that referenced this pull request Jul 28, 2022
(cherry picked from commit 1c167ab)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants