Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nsupdate when updating NS record #5112

Merged
merged 6 commits into from Aug 20, 2022
Merged

Fix nsupdate when updating NS record #5112

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16eb275
Fix nsupdate when updating NS record
Aug 12, 2022
d5d3f74
Changelog fragment
Aug 12, 2022
913854c
Update changelogs/fragments/5112-fix-nsupdate-ns-entry.yaml
lungj Aug 13, 2022
2aff477
Switch to fallback to AUTHORITY instead of using with NS type.
Aug 14, 2022
8520d51
Update plugins/modules/net_tools/nsupdate.py
lungj Aug 14, 2022
2af5955
Update plugins/modules/net_tools/nsupdate.py
lungj Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/5112-fix-nsupdate-ns-entry.yaml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- nsupdate - compatibility with NS records (https://github.com/ansible-collections/community.general/pull/5112).
2 changes: 1 addition & 1 deletion plugins/modules/net_tools/nsupdate.py
View file
Open in desktop
Expand Up @@ -427,7 +427,7 @@ def ttl_changed(self):
if lookup.rcode() != dns.rcode.NOERROR:
self.module.fail_json(msg='Failed to lookup TTL of existing matching record.')

current_ttl = lookup.answer[0].ttl
current_ttl = lookup.answer[0].ttl if lookup.answer else lookup.authority[0].ttl
lungj marked this conversation as resolved.
Show resolved Hide resolved
return current_ttl != self.module.params['ttl']


Expand Down