dig: Fix evaluation of boolean parameters

[mu1f407]

SUMMARY

Fixes evaluation of falsy boolean parameters in dig lookup plugin.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.general.dig lookup plugin

ADDITIONAL INFORMATION

Plugin currently uses bool() function to convert string boolean values to boolean type. This function in not the right one for this task as is returns True for every non-empty string:

Python 3.9.7 (default, Sep 13 2021, 08:18:39) 
[GCC 8.5.0 20210514 (Red Hat 8.5.0-3)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> bool('False')
True
>>> bool('no')
True

There is function in ansible.module_utils for this which correctly handles string-to-boolean conversion.

I also added tests for dig lookup and this issue specifically.

[ansibullbot]

cc @jpmens
click here for bot help

[jpmens]

Thank you, @mu1f407

[jpmens]

shipit

[mu1f407]

Done. Thanks for hints @felixfontein.

[ansibullbot]

The test licenses failed with 2 errors:

tests/integration/targets/lookup_dig/meta/main.yml:0:0: found no copyright notice
tests/integration/targets/lookup_dig/meta/main.yml:0:0: must have at least one license

click here for bot help

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

[patchback]

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3c2d7eb on top of patchback/backports/stable-4/3c2d7eb193ac6676a054396c2d41328f23862104/pr-5129

Backporting merged PR #5129 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/community.general.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-4/3c2d7eb193ac6676a054396c2d41328f23862104/pr-5129 upstream/stable-4

4. Now, cherry-pick PR dig: Fix evaluation of boolean parameters #5129 contents into that branch:

   $ git cherry-pick -x 3c2d7eb193ac6676a054396c2d41328f23862104

   If it'll yell at you with something like fatal: Commit 3c2d7eb193ac6676a054396c2d41328f23862104 is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x 3c2d7eb193ac6676a054396c2d41328f23862104

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR dig: Fix evaluation of boolean parameters #5129 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-4/3c2d7eb193ac6676a054396c2d41328f23862104/pr-5129

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3c2d7eb193ac6676a054396c2d41328f23862104/pr-5129

Backported as #5137

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[felixfontein]

@mu1f407 thanks for fixing this!
@jpmens thanks for reviewing!